You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a short description of what changes you made, why you made them, and any other context that you think might be helpful for someone to better understand what is contained in this pull request. This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.
Screenshot
If relevant, add a screenshot or two of the changes you made.
Note
Upgrades Qwik/Qwik City to 1.17 with Vite 5 and bundler module resolution, plus a null-safe hover animation lookup in live-edit styles.
Dependencies/Config:
Upgrade @builder.io/qwik and @builder.io/qwik-city to ^1.17.1 in packages/sdks/e2e/qwik-city and packages/sdks/snippets/qwik-city.
Update vite to ^5.4.0 and vite-tsconfig-paths to ^4.2.1 in the same packages.
Switch TS moduleResolution to "bundler" in tsconfig.json for both Qwik City projects.
Bump devDependency @builder.io/qwik to ^1.17.1 in packages/sdks/output/qwik/package.json.
Code:
In live-edit-block-styles.lite.tsx, make hover animation access null-safe using optional chaining when reading processedBlock.animations.
Written by Cursor Bugbot for commit 4d4c73d. This will update automatically on new commits. Configure here.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Bug: Peer Dependency Mismatch After Qwik Upgrade
Upgrading @builder.io/qwik to ^1.17.1 introduces a peer dependency conflict. Qwik 1.17.x requires vite: ">=5 <8" but the package still specifies vite: "^4.5.11". This mismatch will cause peer dependency warnings or errors during installation and may lead to runtime incompatibilities.
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Description
Add a short description of what changes you made, why you made them, and any other context that you think might be helpful for someone to better understand what is contained in this pull request. This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.
Screenshot
If relevant, add a screenshot or two of the changes you made.
Note
Upgrades Qwik/Qwik City to 1.17 with Vite 5 and bundler module resolution, plus a null-safe hover animation lookup in live-edit styles.
@builder.io/qwikand@builder.io/qwik-cityto^1.17.1inpackages/sdks/e2e/qwik-cityandpackages/sdks/snippets/qwik-city.viteto^5.4.0andvite-tsconfig-pathsto^4.2.1in the same packages.moduleResolutionto"bundler"intsconfig.jsonfor both Qwik City projects.@builder.io/qwikto^1.17.1inpackages/sdks/output/qwik/package.json.live-edit-block-styles.lite.tsx, make hover animation access null-safe using optional chaining when readingprocessedBlock.animations.Written by Cursor Bugbot for commit 4d4c73d. This will update automatically on new commits. Configure here.