Skip to content

test qwik sdk with Qwik upgrade to 1.17.1 version #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+1,066 −186
Open

test qwik sdk with Qwik upgrade to 1.17.1 version #4180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a72a233
test qwik sdk with Qwik upgrade to 1.17.1 version
sanyamkamat Nov 7, 2025
0ac389b
make tests pass
sanyamkamat Nov 11, 2025
e1162a9
update qwik-cty version
sanyamkamat Nov 11, 2025
cc4bbf5
use latest compatible vite
sanyamkamat Nov 11, 2025
4d4c73d
more version updates
sanyamkamat Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/sdks/e2e/qwik-city/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
"serve": "yarn run preview"
},
"devDependencies": {
"@builder.io/qwik": "^1.9.1",
"@builder.io/qwik-city": "^1.9.1",
"@builder.io/qwik": "^1.17.1",
"@builder.io/qwik-city": "^1.17.1",
"@types/node": "^18.11.18",
"node-fetch": "3.3.0",
"typescript": "^5.1.6",
"vite": "^4.5.11",
"vite-tsconfig-paths": "3.5.0"
"vite": "^5.4.0",
"vite-tsconfig-paths": "^4.2.1"
},
"dependencies": {
"@builder.io/sdk-qwik": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/sdks/e2e/qwik-city/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"strict": true,
"forceConsistentCasingInFileNames": true,
"resolveJsonModule": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"esModuleInterop": true,
"skipLibCheck": true,
"incremental": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/sdks/output/qwik/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"isolated-vm": "^6.0.0"
},
"devDependencies": {
"@builder.io/qwik": "^1.5.1",
"@builder.io/qwik": "^1.17.1",
Copy link

@cursor cursor bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer Dependency Mismatch After Qwik Upgrade

Upgrading @builder.io/qwik to ^1.17.1 introduces a peer dependency conflict. Qwik 1.17.x requires vite: ">=5 <8" but the package still specifies vite: "^4.5.11". This mismatch will cause peer dependency warnings or errors during installation and may lead to runtime incompatibilities.

Fix in Cursor Fix in Web

"@builder.io/sdks": "workspace:*",
"@types/node": "latest",
"typescript": "5.5.2",
Expand Down
8 changes: 4 additions & 4 deletions packages/sdks/snippets/qwik-city/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
"serve": "yarn run preview"
},
"devDependencies": {
"@builder.io/qwik": "^1.9.1",
"@builder.io/qwik-city": "^1.9.1",
"@builder.io/qwik": "^1.17.1",
"@builder.io/qwik-city": "^1.17.1",
"@types/node": "^18.11.18",
"node-fetch": "3.3.0",
"typescript": "^5.1.6",
"vite": "^4.5.11",
"vite-tsconfig-paths": "3.5.0"
"vite": "^5.4.0",
"vite-tsconfig-paths": "^4.2.1"
},
"dependencies": {
"@builder.io/sdk-qwik": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion packages/sdks/snippets/qwik-city/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"strict": true,
"forceConsistentCasingInFileNames": true,
"resolveJsonModule": true,
"moduleResolution": "node",
"moduleResolution": "bundler",
"esModuleInterop": true,
"skipLibCheck": true,
"incremental": true,
Expand Down
4 changes: 2 additions & 2 deletions packages/sdks/src/components/block/components/live-edit-block-styles.lite.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ export default function LiveEditBlockStyles(props: LiveEditBlockStylesProps) {
: '';

const hoverAnimation =
this.processedBlock.animations &&
this.processedBlock.animations.find((item) => item.trigger === 'hover');
this.processedBlock?.animations &&
this.processedBlock?.animations?.find((item) => item.trigger === 'hover');

let hoverStylesClass = '';
if (hoverAnimation) {
Expand Down
Loading
Loading