refactor(core): extract configuration polling and runtime modules by somethingwithproof · Pull Request #646 · Cacti/spine

somethingwithproof · 2026-10-09T21:30:48Z

Extract configuration, logging, result handling, privileges, startup/workers, database, probes, scripts, and SNMP session construction into focused C translation units. Keep the polling interfaces and production-linked contracts intact through the extraction.

This update also fixes an observed concurrency failure: the MariaDB/SNMPv3 integration poll produced only 23 results for 24 hosts after a USM encryption error. Session construction previously locked only the session-open call, while authenticated requests could run against shared Net-SNMP USM state. Synchronize complete session construction and SNMPv3 transactions with the existing session-cleanup lock. SNMPv1/v2c transactions retain concurrent independent sessions. SNMPv3 transactions serialize inside the library, including configured timeouts, so slow or unreachable v3 devices can reduce throughput. Document the tradeoff and the Net-SNMP threading limitations in the README.

Fixture fixes wait for the final TCP database and a responsive SNMP agent, isolate Compose projects, preserve the poller's exit status, and wait for the child process-group handshake before injecting wait failures. No check or finding is suppressed.

Validation on isolated copied source trees with disposable endpoints:

SNMPv3 session unit tests: 24 passed, including lock release and cancellation-state restoration on success, timeout, and error.
macOS native module build and regression suite: 14 passed, 2 prerequisite skips, no failures.
Final stack Linux arm64 ASan/UBSan suite: 17 passed, 2 prerequisite skips, no failures or sanitizer findings.
Real SNMPv3 concurrency fixture: five repeated polls each at 1, 4, and 12 workers; all 360 host polls accounted for; 122 assertions passed, no failures.

GitHub checks validate the published commit separately. No live Cacti database, production device, installation, or privilege change was used.

Review and merge after #654, then continue with #648. See the series index.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

…638) Introduce bounded native interfaces and grouped runtime state, then link regression and fault contracts against the real poller implementations. The contracts capture CLI/configuration input, availability combinations, SNMP request/response ownership, script framing, reindexing, output persistence, worker completion and shutdown. This foundational change is larger because the shared interfaces and their existing production contracts must move together; later changes have separate review boundaries. Step 1/14 of the complete C17/native-correctness series. Base: develop. Earlier validation, before this review follow-up, in isolated copied snapshots on Linux arm64: - Clean GCC build and make check: 13 passed, 0 existing prerequisite skips, 0 failures. - ASan/UBSan: 12 passed, 1 existing privilege/allocator-interposition prerequisite skips, 0 failures; no sanitizer findings. - Production source/profile integrity verification against disposable MariaDB and loopback SNMP fixtures passed. - Release archive extracted into a separate source tree and built/tested out of tree; fuzz checks passed. Earlier local profiles retain source hashes for the copied validation tree; GitHub checks validate the published commit. No production database/device, host installation or live privilege change is part of validation. Existing prerequisite skips were retained; no test or finding was suppressed to obtain a pass. The worker contracts publish owned heap state and release it only after joining workers and restoring the runtime table. Coverage counters use atomic updates; cppcheck receives an explicit model of the fatal exit contract. Fixture images use public mirrors to avoid shared Docker Hub pull limits. Series navigation: review and merge in order. Every PR targets the preceding branch so its diff contains one step. 1. [refactor(core): add bounded native interfaces and polling contracts](#638) 2. [fix(privileges): drop root before input and retain owned ICMP sockets](#639) 3. [fix(poller): isolate worker failures and bound database reconnects](#640) 4. [fix(results): normalize output and unify SNMP batch persistence](#641) 5. [fix(runtime): bound probe retries and validate CLI and configuration](#642) 6. [build: select GNU C17 explicitly and probe hardening support](#643) 7. [fix(threads): size worker stacks and guard size arithmetic](#644) 8. [refactor(c17): simplify ownership guards and share test support](#645) 9. [refactor(core): extract configuration polling and runtime modules](#646) 10. [fix(boundaries): validate script slots and make cleanup portable](#647) 11. [refactor(layout): organize responsibilities and separate main from runtime](#648) 12. [docs(license): adopt SPDX notices and retain contributor credits](#649) 13. [test(runtime): measure all suites and cover protocol boundaries](#650) 14. [build(ci): validate connectors time width and native C17 modules](#651) Review follow-up (2026-10-09): Publish the decoded GET/GETNEXT status back to the host so availability checks observe exception and missing-response failures, while preserving the legacy transport-success behavior for agent PDU errors. Updated step 1 snapshot: isolated Linux arm64 build and make check passed (13 passed, no skips or failures). The restacked tip passes all five clang-tidy gate regression tests and real clang-tidy analysis (26 reviewed baseline findings, no new findings). Actionlint and matching DCO trailers pass. The setuid test also passes when run in the separate disposable root container. GitHub checks validate the updated published commits; earlier profile/archive/sanitizer evidence above belongs to the previous revisions. --------- Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Apply the behavior-preserving C17 cleanup to allocations, array sizing, declarations, guards and ownership. Preserve the captured runtime baseline and reorganize reusable test state, PHP child fixtures and release/debug helpers. Tests cover keyword locking, process selection, helper arguments and archive contents; the bounded memory-soak harness remains available. Step 8/14 of the complete C17/native-correctness series. Base: the preceding series branch; merge/review in order so this PR shows only its own step. Earlier validation, before this review follow-up, in isolated copied snapshots on Linux arm64: - Clean GCC build and make check: 18 passed, 1 existing prerequisite skips, 0 failures. - ASan/UBSan: 17 passed, 2 existing privilege/allocator-interposition prerequisite skips, 0 failures; no sanitizer findings. - Production source/profile integrity verification against disposable MariaDB and loopback SNMP fixtures passed. - Release archive extracted into a separate source tree and built/tested out of tree; fuzz checks passed. Earlier local profiles retain source hashes for the copied validation tree; GitHub checks validate the published commit. No production database/device, host installation or live privilege change is part of validation. Existing prerequisite skips were retained; no test or finding was suppressed to obtain a pass. Series navigation: [Series index](#638); [previous step](#644). [Next step](#646). Review follow-up (2026-10-09): Restacked on the corrected preceding branches. The SNMP status fix is introduced in #638, the reindex/completion fixes in #640, and focused regression coverage in #650. Restacked tip validation: isolated Linux arm64 build and make check passed (18 passed, 1 setuid prerequisite skip, no failures). GitHub checks validate the updated published commits; earlier profile/archive/sanitizer evidence above belongs to the previous revisions. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Validate PHP reader process tables and configured/array slot bounds before descriptor access or recovery, and keep owned undefined-result behavior. Make ctype input unsigned, bound shared formatting, enforce monotonic child cleanup budgets and keep BSD spawn/descriptor behavior portable. Tests cover invalid slots, log boundaries, child cleanup, startup and release helpers. Step 10/14 of the complete C17/native-correctness series. Base: the preceding series branch; merge/review in order so this PR shows only its own step. Earlier validation, before this review follow-up, in isolated copied snapshots on Linux arm64: - Clean GCC build and make check: 18 passed, 1 existing prerequisite skips, 0 failures. - ASan/UBSan: 17 passed, 2 existing privilege/allocator-interposition prerequisite skips, 0 failures; no sanitizer findings. - Production source/profile integrity verification against disposable MariaDB and loopback SNMP fixtures passed. - Release archive extracted into a separate source tree and built/tested out of tree; fuzz checks passed. Earlier local profiles retain source hashes for the copied validation tree; GitHub checks validate the published commit. No production database/device, host installation or live privilege change is part of validation. Existing prerequisite skips were retained; no test or finding was suppressed to obtain a pass. Series navigation: [Series index](#638); [previous step](#646). [Next step](#648). Review follow-up (2026-10-09): Restacked on the corrected preceding branches. The SNMP status fix is introduced in #638, the reindex/completion fixes in #640, and focused regression coverage in #650. Restacked tip validation: isolated Linux arm64 build and make check passed (18 passed, 1 setuid prerequisite skip, no failures). GitHub checks validate the updated published commits; earlier profile/archive/sanitizer evidence above belongs to the previous revisions. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

…groups Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

…pe split Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

# Conflicts: # snmp.c # tests/unit/test_snmpv3_session.c Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

somethingwithproof requested a review from a team as a code owner October 9, 2026 21:30

somethingwithproof requested review from TheWitness and removed request for a team October 9, 2026 21:30

somethingwithproof force-pushed the refactor/c17-series-09-modules branch from 3ec090f to f8e9611 Compare October 9, 2026 21:44

This was referenced Oct 9, 2026

refactor(core): add bounded native interfaces and polling contracts #638

Merged

refactor(c17): simplify ownership guards and share test support #645

Merged

fix(boundaries): validate script slots and make cleanup portable #647

Merged

somethingwithproof force-pushed the refactor/c17-series-08-idioms branch from 6537cb3 to 33a299e Compare October 9, 2026 21:54

somethingwithproof force-pushed the refactor/c17-series-09-modules branch 2 times, most recently from 10aa002 to 260284c Compare October 9, 2026 23:01

somethingwithproof force-pushed the refactor/c17-series-08-idioms branch from 33a299e to 6c8798e Compare October 9, 2026 23:02

somethingwithproof added 2 commits October 9, 2026 16:29

refactor(c17): simplify ownership guards and share test support

8bdf685

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

refactor(core): extract configuration polling and runtime modules

4552431

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

somethingwithproof force-pushed the refactor/c17-series-09-modules branch from 260284c to 4552431 Compare October 10, 2026 00:17

somethingwithproof force-pushed the refactor/c17-series-08-idioms branch from 6c8798e to 8bdf685 Compare October 10, 2026 00:17

somethingwithproof added the enhancement label Oct 10, 2026

somethingwithproof self-assigned this Oct 10, 2026

Base automatically changed from refactor/c17-series-08-idioms to refactor/c17-series-07-thread-stacks October 11, 2026 00:07

somethingwithproof added 10 commits October 10, 2026 20:10

fix(merge): carry updated safety checks into extracted modules

5bf21e6

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

test(merge): propagate shared socket fixture correction

efcac8c

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

fix(merge): retain grouped reader configuration after module extraction

0f6fbe1

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

test(integration): await final database listener and spawned process …

d5b4d62

…groups Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

test(merge): propagate lifetime and remote pool fixture fixes

f879433

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

test(php): isolate fixture and preserve poller exit status

994dfd7

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

fix(merge): propagate workflow cancellation ownership

41a1778

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

fix(merge): retain ancestry after privilege squash merge

7cd14ff

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

ci(merge): propagate macOS failure diagnostics

2bc4372

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

somethingwithproof added 2 commits October 10, 2026 18:18

test(merge): propagate deterministic descriptor alias fixture

53b74b8

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

fix(merge): retain bounded stacks and config fixture after series sco…

dcecaad

…pe split Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

This was referenced Oct 11, 2026

fix(threads): size worker stacks and guard size arithmetic #644

Open

refactor(c17): isolate native helper hardening and support fixtures #653

Closed

somethingwithproof changed the base branch from refactor/c17-series-07-thread-stacks to fix/review-step08-native-helpers October 11, 2026 01:29

somethingwithproof mentioned this pull request Oct 11, 2026

refactor(c17): isolate native helper hardening and support fixtures #654

Open

somethingwithproof changed the base branch from fix/review-step08-native-helpers to refactor/c17-series-08-native-helpers October 11, 2026 01:37

somethingwithproof added 2 commits October 10, 2026 18:50

fix(snmp): synchronize shared SNMPv3 library state

32aa868

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

fix(snmp): carry shared-state synchronization into extracted modules

3bfefb3

# Conflicts: # snmp.c # tests/unit/test_snmpv3_session.c Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

somethingwithproof force-pushed the refactor/c17-series-09-modules branch from 268aa8d to 3bfefb3 Compare October 11, 2026 01:59

somethingwithproof mentioned this pull request Oct 11, 2026

Refactor runtime ownership and worker lifecycle #609

Open

7 tasks

Navigation Menu

Repository navigation

refactor(core): extract configuration polling and runtime modules - #646

refactor(core): extract configuration polling and runtime modules#646
somethingwithproof wants to merge 16 commits into
refactor/c17-series-08-native-helpersfrom
refactor/c17-series-09-modules

somethingwithproof commented Oct 9, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

somethingwithproof commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

somethingwithproof commented Oct 9, 2026 •

edited

Loading