Repository navigation
Conversation
- Ran the color-roles codemod on gamut, then resolved every leftover (splits, retired and pending names, old palette colors, runtime names) from design's component map in colorSystem/migration.ts. - Buttons follow design's button map: action families per variant, interface merges into primary, text-inverse labels, one action-primary focus ring, state veils for StrokeButton and TextButton, disabled knockout, CTAButton's offset shadow on action-neutral. - Card variants become surfaces, with the brand gradient for yellow and hyper; Alert's gradient layer moves to utils/gradientLayer for both. - Stories that painted old palette colors use roles or mode scopes. - BREAKING: old themes don't define the roles, so components lose their colors on core, admin, platform, percipio and lxStudio until they're rebuilt as brands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mponents Picks up #50's tokensCss injection in GamutProvider and the merge of main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mponents Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s brands Each old theme becomes a brand of the generated color system, so every theme defines every role and components on roles work under all of them. - Hues come from what the old theme rendered in each job, including what it inherited from core. Page backgrounds, text and yellow are pinned. Percipio and lxStudio keep core's yellow accent and dark mode. - Fonts, weights, elevation and lxStudio's radii are unchanged. createBrandTheme takes `borderRadii` and `initialMode`; platform starts in dark mode and adds its editor-* colors with their old values. - The two-color gradient pairs primary with accent-alt for every brand with a yellow accent, as design asked for Original Codecademy. - validate-tokens treats a polished rounding tie as agreement with the content-mode table and reports it (percipio primary-600). - The styling contract test only reads the blocks of the brand it tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 6 tasks
Design's card map (Interactive) puts a `state-hover` veil over the card's own fill and darkens the edge to `border-strong` on hover. The veil is a layer behind the content, so it tints the fill and a brand gradient but not the text, and it keys off the same wrapper hover as the elevation lift. The theme's elevation hover stays until elevation tokens exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ran the color-roles codemod over packages/styleguide and resolved every split, retirement and old palette color it flagged, following design's migration map and the choices gamut's components already made. Stories and docs that list color names now show roles, MDX examples included. The Storybook provider sets the page surface from the selected theme's `background-current` instead of a white/navy palette pair. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…olor-components Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ption Every theme in the toolbar is now a brand of the generated color system. Old core has no roles, so components on roles render without color under it; Original Codecademy is its rebuild. The core theme docs page shows Original Codecademy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
packages/.storybook is the config Storybook runs; the theme default change only belongs there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gacy-brands Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Design feedback on the comparison page (2026-10-29): pinned navy-800 carries much more chroma than the generated surfaces beside it. As for Original Codecademy (#52), lxStudio uses the generated step at navy's hue. Admin and platform inherit Original Codecademy's pins, so they follow; platform's blue-0 and the near-white pages are nearly achromatic and stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…olor-components Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Design feedback on the comparison page (2026-10-29): selection and navigation tags shouldn't have a fill. - Navigation and suggestion tags rest on a transparent fill instead of surface-raised, so they don't show as a white box on beige or paper pages. Hover and press stay veils. - A disabled tag drops the action-disabled fill. With nothing under it, the knockout label becomes the action-disabled ink; a disabled selection chip keeps an inset border-default edge so it doesn't resize. - The selection chip at rest stays a text-subtle chip, per design's map. - Adds Tag's first unit tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dreamwasp
commented
Oct 29, 2026
dreamwasp
left a comment
Contributor
Author
There was a problem hiding this comment.
Fix from design feedback on the components comparison page (2026-10-29).
6 of 7 tasks
- percipioTheme, the PercipioTheme type and the percipio brand are removed, with its Storybook theme option and Foundations page. The Percipio fonts and elevation stay, since skillsoftTheme and lxStudioTheme use them. - lxStudio's yellow is generated rather than pinned; only its near-white page stays pinned, and its dark primary stays sapphire. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-legacy-brands - admin, platform and lxStudio take the soft elevation drawn in the shadow roles; only Original Codecademy keeps the hard offset (design's sandbox, df33b47: the hard offset is the Codecademy theme's only). - Original Codecademy's overrides split into coreFamilyOverrides (the pins, the yellow dark primary, the gradient), which admin and platform share, and its own transparent shadow-ambient, which they don't. - Tokens regenerated; theme snapshots updated for the shadow roles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-components Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… cass-gmt-1825-color-legacy-brands
…s' into cass-gmt-1825-color-components
Ports design's 2026-11-03 component map (gamut-sandbox df33b47): - Card: variants are default and brand (old white, beige and navy become default; yellow and hyper become brand). Every card keeps a border-subtle hairline. An interactive card has the raised shadow at rest and the state-hover veil with the raised-hover shadow on hover; the border no longer changes. A card that isn't interactive has no shadow. The outline offset is drawn in shadow-key. - Menus, popovers, tooltips, toasts and the SelectDropdown menu take a border-subtle hairline backed by the theme's raised shadow (a placeholder until design defines an overlay depth). - CTAButton's shadow comes from the theme's elevation. - Overlay's scrim is shadow-scrim; Flyout's panel has a border-subtle inner edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dreamwasp
commented
Nov 4, 2026
dreamwasp
left a comment
Contributor
Author
There was a problem hiding this comment.
Port of design's sandbox update, 2026-11-03 (gamut-sandbox df33b47). Notes on the lines below.
2 of 6 tasks
…heme Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mponents # Conflicts: # packages/gamut/src/Card/Card.stories.tsx # packages/gamut/src/Form/inputs/SelectDropdown/core/styles.ts
…-subtle in a SelectDropdown story
ctaButtonElevation took `{ theme: Theme }`, which createButtonComponent's
`<T extends ThemeProps>` argument rejects, so the gamut build failed.
The SelectDropdown story main added in #47 used `text-secondary`, which
is `text-subtle` now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ate-stylis symptom Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 0dc47cf)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 53cce61)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 53cce61)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 53cce61)
# Conflicts: # packages/gamut-styles/src/AssetProvider.fontLoading.test.tsx # packages/gamut-styles/src/AssetProvider.test.tsx # packages/gamut-styles/src/stylingContract.test.tsx # packages/gamut-styles/src/themes/brandElevation.test.ts # packages/styleguide/.storybook/components/Elements/DocsContainer.tsx # packages/styleguide/.storybook/preview.ts # packages/styleguide/.storybook/theming/GamutThemeProvider.tsx # packages/styleguide/src/lib/Foundations/Theme/About.mdx # packages/styleguide/src/lib/Foundations/Theme/CoreTheme.mdx # packages/styleguide/src/lib/Foundations/Theme/CreatingThemes.mdx # packages/styleguide/src/lib/Meta/Usage guide.mdx
Regenerates the theme snapshot for the admin, platform and lxStudio brands. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
# Conflicts: # packages/gamut-brand/src/__tests__/system.test.ts # packages/gamut-styles/src/colorSystem/__tests__/sandboxParity.test.ts # packages/gamut-styles/src/stylingContract.test.tsx # packages/gamut-styles/src/themes/brandElevation.test.ts # packages/gamut-styles/src/themes/theme.test.ts
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
dreamwasp
added a commit
that referenced
this pull request
Nov 20, 2026
Merges main (through 45586df) into the color system branch. - Test files moved beside their sources (#79) and use Vitest (#80). The branch's style tests keep their own content, re-pointed at the new locations, with theme and mock names unchanged. - Modal, Tabs and other main-side story migrations merge clean. - gamut's components are not migrated on this branch (that is #54), so gamut's type check still reports the 284 old-name errors recorded in the spike. This commit's gate is gamut-styles. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
dreamwasp
added a commit
that referenced
this pull request
Nov 20, 2026
Replaces this branch's tree with the color stack as it now stands: the site branch (#67, which includes #63, #59, #54, #66, #58, #52 and #50, each merged with main through 45586df), plus the codemod branch (#53). Static styles (#69) is still out, as before. The preview's earlier head is the parent. This commit only moves the tree forward, so nothing is rewritten. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
# Conflicts: # packages/gamut/src/Anchor/Anchor.stories.tsx # packages/gamut/src/Disclosure/Disclosure.stories.tsx # packages/gamut/src/Form/inputs/SelectDropdown/SelectDropdown.stories.tsx # packages/gamut/src/Tips/PreviewTip/PreviewTip.stories.tsx
@skillsoft/eslint-plugin-gamut
@skillsoft/gamut
@skillsoft/gamut-agent-tools
@skillsoft/gamut-brand
@skillsoft/gamut-codemods
@skillsoft/gamut-icons
@skillsoft/gamut-illustrations
@skillsoft/gamut-patterns
@skillsoft/gamut-styles
@skillsoft/gamut-tests
@skillsoft/variance
commit: |
#88 rewrote story files with the old color names. Renames apply only in color contexts (color props, theme.colors lookups). Splits take the migration map's rule for the common case: text-disabled to text-subtle, border-tertiary to border-subtle, background-hover to state-hover, background to surface-raised, border-primary to border-default, and the two retirements. background-current stays (ColorMode's mechanism). Shadow splits in stories are left for review. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
* build: remove unused macros package and test deps title.macro hasn't been imported since the Storybook 8 move, which relies on auto-titles. Also drop babel-plugin-macros and the unused @testing-library/react-hooks and react-test-renderer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: drop the Date pin from the Storybook setup Story tests pass unpinned and pinned to month-, year-, and leap-day edges. Unpinned, a11y checks also cover the "today" cell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: colocate unit tests next to their source Move every test out of __tests__/tests folders and split codemods' lib.test.ts per module. Still runs on Jest; keep tests out of builds, coverage, and npm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: run unit tests on Vitest Add jsdom and node Vitest projects alongside storybook, port every non-story test from Jest (and agent-tools from node:test), and run them all from one vitest:test Nx target. Jest stays installed until the next PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build: remove Jest Delete the Jest configs, preset, script/jest, and the nx target default. Drop the Jest packages; add jsdom directly for Vitest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build: remove unused Babel configs babel-jest was their last reader; tsdown, Storybook (SWC), and SVGR (configFile: false) never load them. Build output is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drop vitest Nx project left over from main merge Use main's per-package test targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * changeset --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## cass-gmt-1825-color-brands #54 +/- ##
===============================================================
+ Coverage 0 82.07% +82.07%
===============================================================
Files 0 490 +490
Lines 0 40121 +40121
Branches 0 1848 +1848
===============================================================
+ Hits 0 32929 +32929
- Misses 0 7185 +7185
- Partials 0 7 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
main removed Jest and Babel (#81). gamut-brand's test target still pointed at the Jest base config, which is gone. The package now runs under the Vitest node project like the other packages, and its test files import Vitest. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Disabled text uses action-disabled, as the sandbox's migration rule says. The rule is marked as an addition for the next revision, so each text site is commented. The eight stories whose axe check fails on that ink report it as a warning (a11y test: todo) until design decides. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Moves every gamut component onto the color system's roles, following design's component map (gamut-sandbox PR #34, Migration → Components, head
ef1272a). Stacked on #52. Draft, for showing the team what the components look like on the new colors.Screenshots: today's core next to this branch on
skillsoftandoriginalCodecademy, light and dark, 37 stories: https://claude.ai/artifact/QJ836yQVQ6ghKHwawDqE5m (private; ask for access).How it was made
color-rolespreset from feat(gamut-codemods): add a color-roles preset #53 onpackages/gamut/src: 60 files, 273 lines. A second run changes nothing.Buttons (
Button/shared/variants.ts)variantvalues don't change.primary,secondaryanddangermap toaction-primary,action-neutralandaction-danger, each with its own hover and pressed step;interfacemerges into primary (TextButton's interface label istext-default).text-inverse; every variant gets oneaction-primaryfocus ring; disabled fill labels are a knockout.state-hover/state-pressedveils instead of a gray fill and a full inversion.action-neutraluntil there's a shadow role.Components, by design's map
Alert,Toast,Popover,Menu,Tip,Modals,Flyout,Overlay— floating surfaces aresurface-raisedwith aborder-defaultedge; the scrim isbackdrop. Tooltips are no longer black.Form,GridForm,ConnectedForm,Toggle— fields onsurface-raised, hover darkens the outline (border-strong) so blue only means focus; a checked Radio isaction-primary; Toggle disabled isaction-disabledinstead of 50% opacity.Card— yellow and hyper become a featured card on the brand gradient (Alert's gradient layer moved toutils/gradientLayer.tsso both use it); navy is a dark-mode scope; every card gets aborder-subtlehairline.Badge,Tag— filled badges aretext-default/text-subtlebehindtext-inverse; accent issurface-brandwith aborder-defaultedge.Tabs,Disclosure,Pagination,Anchor— block Tabs follow the page's mode instead of forcing dark; Disclosure focus is a ring, not a fill.ProgressBar,DataList,List,BarChart,Markdown,Video,Loading,Typographyand the rest — mapped by the closest documented rule; see "Choices" below.Choices where design has no exact mapping (each has a
/* */comment at the spot)background-currentstays in List, Drawer, DataList empty rows, Card's offset shadow, RadialProgress and Text fade. Design describes asurface-currentalias that every surface sets; that rename belongs in gamut-styles, as a follow-up.surface-brand, not the gradient: the gradient is sized incqw, and a content-sized badge can't be its own container.text-subtle, todayaction-primary, selected day a dark chip withtext-inverse, rangestate-selected, disabledaction-disabled.text-subtle/text-inverse). Design's slot sayssurface-sunkenbut its note says "follows the selection Tag", so this needs design to pick.primary-inverse(Text highlight) →action-primary, flagged for design.whiteandblack.viz-*is a follow-up.Added 2026-10-29
coreThemestill has no roles; Original Codecademy is its rebuild.styleguide: its stories and docs are on roles (52 files). The type check has no color errors left; the 23 remaining errors exist on the base branch too (argTypes alias, InfoTip, BarChart, Tabs types).Card: an interactive card gets design's hover. The border goes toborder-strong, and astate-hoverveil sits under the content, on the same trigger as the existing lift. 4 new tests.Tag(design feedback, 2026-10-29): navigation and suggestion tags have no fill of their own, so they sit on the surface they're on. Disabled tags drop theaction-disabledfill, takeaction-disabledink, and keep their edge. The selection chip at rest stays a dark chip, per design's map. Adds Tag's first tests.background-selectedas a resting panel →surface-sunkentext-disabledas muted helper text →text-subtlebackground-contrastas a label on a fill →text-inversedangeras red text →text-errorsurface-brandKnown gaps
undefined.viz-*is a follow-up.PR Checklist
.changeset/color-roles-components.md)Testing Instructions
Stacked on #52 (which is stacked on #50). The full stack is in #73.
yarn nx build gamut→ passes.yarn nx test gamut-styles→ 15 suites, 298 tests pass.yarn workspace @skillsoft/gamut-styles validate:tokens→ "all checks pass".yarn nx test gamut→ 65 suites, 965 tests pass.🤖 Generated with Claude Code