Repository navigation
Conversation
…s brands Each old theme becomes a brand of the generated color system, so every theme defines every role and components on roles work under all of them. - Hues come from what the old theme rendered in each job, including what it inherited from core. Page backgrounds, text and yellow are pinned. Percipio and lxStudio keep core's yellow accent and dark mode. - Fonts, weights, elevation and lxStudio's radii are unchanged. createBrandTheme takes `borderRadii` and `initialMode`; platform starts in dark mode and adds its editor-* colors with their old values. - The two-color gradient pairs primary with accent-alt for every brand with a yellow accent, as design asked for Original Codecademy. - validate-tokens treats a polished rounding tie as agreement with the content-mode table and reports it (percipio primary-600). - The styling contract test only reads the blocks of the brand it tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gacy-brands Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Design feedback on the comparison page (2026-10-29): pinned navy-800 carries much more chroma than the generated surfaces beside it. As for Original Codecademy (#52), lxStudio uses the generated step at navy's hue. Admin and platform inherit Original Codecademy's pins, so they follow; platform's blue-0 and the near-white pages are nearly achromatic and stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dreamwasp
left a comment
There was a problem hiding this comment.
Fix from design feedback on the brand comparison page (2026-10-29).
| * reads it) and core's dark mode, primary yellow included. Old lxStudio has | ||
| * no second accent, so `accent-alt` stays on the gamut default (sandbox D4). | ||
| * | ||
| * Navy isn't pinned, as for Original Codecademy: pinned, it carries much |
There was a problem hiding this comment.
Design feedback (2026-10-29): the pinned navy at neutral-dark-1100 looked out of place next to the generated surfaces. Same fix as Original Codecademy in #52: navy isn't pinned, and the generated step at its hue is used. Admin and platform pick this up through Original Codecademy's overrides. The near-white pages (#FAFBFC, platform's blue-0) and percipio's #222325 are nearly achromatic, so they stay pinned.
- percipioTheme, the PercipioTheme type and the percipio brand are removed, with its Storybook theme option and Foundations page. The Percipio fonts and elevation stay, since skillsoftTheme and lxStudioTheme use them. - lxStudio's yellow is generated rather than pinned; only its near-white page stays pinned, and its dark primary stays sapphire. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-legacy-brands - admin, platform and lxStudio take the soft elevation drawn in the shadow roles; only Original Codecademy keeps the hard offset (design's sandbox, df33b47: the hard offset is the Codecademy theme's only). - Original Codecademy's overrides split into coreFamilyOverrides (the pins, the yellow dark primary, the gradient), which admin and platform share, and its own transparent shadow-ambient, which they don't. - Tokens regenerated; theme snapshots updated for the shadow roles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| name: 'admin', | ||
| fontFamily, | ||
| fontWeight, | ||
| elevation: softElevation, |
There was a problem hiding this comment.
Design's sandbox update, 2026-11-03: the hard offset shadow is for the Codecademy theme only, so admin, platform and lxStudio take the soft shadow drawn in shadow-key and shadow-ambient. Before this, their coreElevation read shadow-primary, which brand themes don't define, so their shadows rendered undefined.
| * primary with accent-alt instead of the yellow accent, so it reads blue to | ||
| * violet rather than blue to yellow (design, Stacey, 2026-10-28). | ||
| */ | ||
| export const coreFamilyOverrides: BrandOverrides = { |
There was a problem hiding this comment.
Admin and platform spread Original Codecademy's overrides, which would also have made their shadow-ambient transparent and dropped half of the soft shadow. The shared pins now live in coreFamilyOverrides; the transparent ambient layer is Original Codecademy's alone. brandElevation.test.ts checks that only Original Codecademy overrides it.
… cass-gmt-1825-color-legacy-brands
…-components Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…heme Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… cass-gmt-1825-color-legacy-brands
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
… cass-gmt-1825-color-legacy-brands # Conflicts: # .changeset/color-system-brands.md # packages/.storybook/components/Elements/DocsContainer.tsx # packages/.storybook/preview.ts # packages/.storybook/theming/GamutThemeProvider.tsx # packages/gamut-styles/src/__tests__/AssetProvider.test.tsx # packages/gamut-styles/src/__tests__/fontLoading.test.tsx # packages/gamut-styles/src/__tests__/stylingContract.test.tsx # packages/gamut-styles/src/colorSystem/README.md # packages/gamut-styles/src/themes/__tests__/__snapshots__/theme.test.ts.snap # packages/gamut-styles/src/themes/__tests__/theme.test.ts # packages/gamut-styles/src/themes/admin.ts # packages/gamut-styles/src/themes/index.ts # packages/gamut-styles/src/themes/lxStudio.ts # packages/gamut-styles/src/themes/platform.ts # packages/gamut-styles/src/tokens/generated/tokens.css # packages/gamut-styles/src/tokens/generated/tokensCss.ts # packages/gamut/src/Alert/__tests__/Alert.test.tsx
Vite failed with 'The symbol skillsoftTheme has already been declared' in GamutThemeProvider and DocsContainer. Introduced by the brands merge. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Roboto 500 and 700 share one bold file, so the preload list had two links with the same key (the file URL), and React warned about duplicate keys. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The skill triaged scope-swap only. Add a color-roles section: the dry-run and real-run steps, what the warnings and color-roles: comments mean and what to do for each, the checks before calling it done, and what not to do. The description names the preset so the skill triggers on color-name work. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 6f0e3de)
…on and cover every preset The skill covered scope-swap only. It's now gamut-migration: a presets table, one workflow for all presets, a section per preset (scope-swap, color-roles), and a section on documenting a new preset. Renames the changeset to match. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit f5bf30b)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 15c7699)
…section Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 80522ce)
…ion skill - next-config: removing esmExternals: false is necessary but not always enough. Build each app and fix the routes that still fail at prerender. - CI: the job that runs sync-gamut-deps fails too, so change it with the script. - resolutions: yarn why can list two lock locators after a pin, with one copy installed. Check node_modules. - tsconfig-dom: the codemod warns only where gamut is imported. - Missing peers: @vidstack/react, react-player and stylis, with the range to add by hand. - color-roles: a palette name can map to different roles by slot, so use the context in the comment. Keep each app's theme, since the choice changes the spacing scale. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit a0f18dc)
…gration skill Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit bb684b9)
…igration skill Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit b35dc09)
… skill Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 552d148)
…ser in the gamut-migration skill Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 7d92c95)
…ate-stylis symptom Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 0dc47cf)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> (cherry picked from commit 53cce61)
There was a problem hiding this comment.
🟡 Changes recommended
Unsupported Core theme keys can crash Storybook before rendering, while dark-mode JSON tokens and editor defaults diverge from the configured themes.
2 open issues
What changed in this PR
Extends the generated color system from #52 to Admin, Platform, and LX Studio, preparing those themes for the component color-role migration in #54. It also updates Storybook and documentation for the move from Percipio to Skillsoft.
Changes:
- Adds brand palettes, shared overrides, generated tokens, and theme-factory options for initial mode and border radii.
- Preserves theme-specific typography and editor colors, expands theme tests, and deduplicates font preloads.
- Removes Percipio documentation and toolbar entries, and expands migration guidance to cover color roles.
| File | Description |
|---|---|
packages/variance/src/createTheme/createTheme.ts |
Aligns color-variable types with the singular prefix. |
packages/styleguide/src/lib/Meta/Usage guide.mdx |
Removes Percipio from theme instructions. |
packages/styleguide/src/lib/Foundations/Theme/PercipioTheme.mdx |
Deletes the Percipio theme page. |
packages/styleguide/src/lib/Foundations/Theme/CreatingThemes.mdx |
Updates theme-switcher examples. |
packages/styleguide/src/lib/Foundations/Theme/CoreTheme.mdx |
Names Skillsoft in the elevation example. |
packages/styleguide/src/lib/Foundations/Theme/About.mdx |
Updates theme listings and page links. |
packages/styleguide/src/lib/Foundations/shared/percipioElements.tsx |
Removes Percipio documentation tables. |
packages/styleguide/.storybook/theming/GamutThemeProvider.tsx |
Removes Percipio from the theme map. |
packages/styleguide/.storybook/preview.ts |
Removes the Percipio toolbar option. |
packages/styleguide/.storybook/components/Elements/DocsContainer.tsx |
Removes Percipio docs routing. |
packages/gamut/src/Alert/__tests__/Alert.test.tsx |
Adds interaction and color-role assertions. |
packages/gamut-styles/src/tokens/generated/tokens.css |
Adds palettes and overrides for three brands. |
packages/gamut-styles/src/tokens/generated/brands/platform.light.tokens.json |
Adds Platform light-mode token exports. |
packages/gamut-styles/src/tokens/generated/brands/platform.dark.tokens.json |
Adds Platform dark-mode token exports. |
packages/gamut-styles/src/tokens/generated/brands/originalCodecademy.values.ts |
Reorders generated dark-mode overrides. |
packages/gamut-styles/src/tokens/generated/brands/lxStudio.light.tokens.json |
Adds LX Studio light-mode token exports. |
packages/gamut-styles/src/tokens/generated/brands/lxStudio.dark.tokens.json |
Adds LX Studio dark-mode token exports. |
packages/gamut-styles/src/tokens/generated/brands/index.ts |
Exports the three new brand modules. |
packages/gamut-styles/src/tokens/generated/brands/admin.light.tokens.json |
Adds Admin light-mode token exports. |
packages/gamut-styles/src/tokens/generated/brands/admin.dark.tokens.json |
Adds Admin dark-mode token exports. |
packages/gamut-styles/src/themes/platform.ts |
Builds Platform with dark initialization and editor tokens. |
packages/gamut-styles/src/themes/lxStudio.ts |
Builds LX Studio with its typography and radii. |
packages/gamut-styles/src/themes/index.ts |
Exports the rebuilt themes. |
packages/gamut-styles/src/themes/createBrandTheme.ts |
Accepts radii and initial-mode options. |
packages/gamut-styles/src/themes/admin.ts |
Builds Admin from generated brand values. |
packages/gamut-styles/src/themes/__tests__/brandElevation.test.ts |
Expands elevation and ambient-shadow checks. |
packages/gamut-styles/src/colorSystem/README.md |
Revises generator and CSS-contract documentation. |
packages/gamut-styles/src/colorSystem/brands/platform.ts |
Defines Platform hues and its pinned page color. |
packages/gamut-styles/src/colorSystem/brands/originalCodecademy.ts |
Extracts shared core-family overrides. |
packages/gamut-styles/src/colorSystem/brands/lxStudio.ts |
Defines LX Studio hues and gradient overrides. |
packages/gamut-styles/src/colorSystem/brands/index.ts |
Registers the three additional brands. |
packages/gamut-styles/src/colorSystem/brands/admin.ts |
Defines Admin’s primary hue and shared overrides. |
packages/gamut-styles/src/AssetProvider.tsx |
Deduplicates font preload URLs. |
packages/gamut-styles/src/__tests__/stylingContract.test.tsx |
Adds rebuilt themes to styling-contract coverage. |
packages/gamut-styles/src/__tests__/fontLoading.test.tsx |
Exercises switching between distinct themes. |
packages/gamut-styles/src/__tests__/AssetProvider.test.tsx |
Tests shared font files and LX Studio loading. |
packages/gamut-styles/scripts/validate-tokens.ts |
Reports rounded contrast ties separately. |
packages/gamut-docs/src/content/docs/guides/theming-your-app.md |
Removes Percipio from theme choices. |
packages/gamut-docs/src/content/docs/guides/creating-a-custom-theme.md |
Updates theme choices and configuration examples. |
packages/gamut-docs/src/content/docs/foundations/themes.md |
Removes the Percipio listing. |
packages/gamut-docs/src/content/docs/foundations/design-tokens.md |
Names Skillsoft in elevation guidance. |
packages/gamut-docs/src/content/docs/concepts/color-modes.md |
Removes Percipio from palette examples. |
packages/gamut-agent-tools/skills/gamut-scope-swap/SKILL.md |
Removes the superseded scope-swap skill. |
packages/gamut-agent-tools/skills/gamut-review/SKILL.md |
Adjusts table formatting only. |
packages/gamut-agent-tools/skills/gamut-migration/SKILL.md |
Adds combined scope-swap and color-role guidance. |
packages/gamut-agent-tools/skills/gamut-migration/NEXT_EMOTION_INTEROP.md |
Provides Next.js and Emotion migration guidance. |
packages/gamut-agent-tools/skills/gamut-migration/BREAKING_CHANGES.md |
Summarizes package-scope migration changes. |
packages/gamut-agent-tools/README.md |
Documents the expanded migration skill. |
packages/.storybook/theming/GamutThemeProvider.tsx |
Adds rebuilt themes and background selection logic. |
packages/.storybook/preview.ts |
Expands toolbar themes and changes the default. |
packages/.storybook/components/Elements/DocsContainer.tsx |
Adds theme-specific docs routing and changes fallback selection. |
.changeset/gamut-scope-swap-skill.md |
Removes the superseded skill release note. |
.changeset/gamut-migration-skill.md |
Records the expanded migration skill. |
.changeset/color-system-legacy-brands.md |
Records theme rebuilds and Percipio migration guidance. |
.changeset/color-system-brands.md |
Adds color-variable migration guidance. |
Review effort: Balanced
| name: 'Theme', | ||
| description: 'Global theme for components', | ||
| defaultValue: 'skillsoft', | ||
| defaultValue: 'core', |
| tokensCss: `${base.tokensCss}\n@layer tokens{${editorBlock( | ||
| ':root,[data-color-mode="light"]', | ||
| 'light' | ||
| )}${editorBlock('[data-color-mode="dark"]', 'dark')}}`, |
# Conflicts: # packages/gamut-styles/src/AssetProvider.fontLoading.test.tsx # packages/gamut-styles/src/AssetProvider.test.tsx # packages/gamut-styles/src/stylingContract.test.tsx # packages/gamut-styles/src/themes/brandElevation.test.ts # packages/styleguide/.storybook/components/Elements/DocsContainer.tsx # packages/styleguide/.storybook/preview.ts # packages/styleguide/.storybook/theming/GamutThemeProvider.tsx # packages/styleguide/src/lib/Foundations/Theme/About.mdx # packages/styleguide/src/lib/Foundations/Theme/CoreTheme.mdx # packages/styleguide/src/lib/Foundations/Theme/CreatingThemes.mdx # packages/styleguide/src/lib/Meta/Usage guide.mdx
Regenerates the theme snapshot for the admin, platform and lxStudio brands. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Replaces this branch's tree with the color stack as it now stands: the site branch (#67, which includes #63, #59, #54, #66, #58, #52 and #50, each merged with main through 45586df), plus the codemod branch (#53). Static styles (#69) is still out, as before. The preview's earlier head is the parent. This commit only moves the tree forward, so nothing is rewritten. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
* build: remove unused macros package and test deps title.macro hasn't been imported since the Storybook 8 move, which relies on auto-titles. Also drop babel-plugin-macros and the unused @testing-library/react-hooks and react-test-renderer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: drop the Date pin from the Storybook setup Story tests pass unpinned and pinned to month-, year-, and leap-day edges. Unpinned, a11y checks also cover the "today" cell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: colocate unit tests next to their source Move every test out of __tests__/tests folders and split codemods' lib.test.ts per module. Still runs on Jest; keep tests out of builds, coverage, and npm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: run unit tests on Vitest Add jsdom and node Vitest projects alongside storybook, port every non-story test from Jest (and agent-tools from node:test), and run them all from one vitest:test Nx target. Jest stays installed until the next PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build: remove Jest Delete the Jest configs, preset, script/jest, and the nx target default. Drop the Jest packages; add jsdom directly for Vitest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * build: remove unused Babel configs babel-jest was their last reader; tsdown, Storybook (SWC), and SVGR (configFile: false) never load them. Build output is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drop vitest Nx project left over from main merge Use main's per-package test targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * changeset --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # yarn.lock


Overview
Rebuilds
adminTheme,platformThemeandlxStudioThemeas brands of the generated color system, so every theme defines every color role. Without this, those themes lose their colors as soon as components move onto roles (#54).percipioThemeis removed:skillsoftTheme, the new default from #52, replaces it.Brands
colorSystem/brands/{admin,platform,lxStudio}.ts: each slot takes its hue from what the old theme rendered in that job, including what it inherited from core. Navy and beige aren't pinned (design, 2026-10-29): pinned, they carried far more chroma than the generated surfaces beside them.coreFamilyOverrides, but not its transparentshadow-ambient.Themes
themes/{admin,platform,lxStudio}.ts: built withcreateBrandTheme. Fonts, weights and lxStudio's radii are unchanged. Elevation is the soft shadow drawn in the shadow roles (design's sandbox,df33b47); only Original Codecademy keeps the hard offset.createBrandThemetakesborderRadiiandinitialMode.platformThemestarts in dark mode and adds itseditor-*code editor colors with their old values, declared only by its ownGamutProvider.percipioTheme, thePercipioThemetype, the percipio brand, its Storybook theme option and its Foundations page are removed.skillsoftThemekeeps Percipio's fonts, font weights and resting shadow, with colors generated from the Skillsoft brand's hues.Checks and tests
shadow-ambienttransparent.What to look at
tokens.cssgrows from 30 KB to 55 KB raw, or 3.6 to 4.2 KB gzipped, because every brand's palette ships to every app.interfaceon hyper (no interface role) and old hover shades (hover grades are design's).PR Checklist
stacey/color-tokens-v2).changeset/color-system-legacy-brands.md)Testing Instructions
yarn workspace @skillsoft/gamut-styles build:tokens: no diff insrc/tokens/generated/.yarn workspace @skillsoft/gamut-styles validate:tokens: every check passes for all five brands.npx jest -c packages/gamut-styles/jest.config.ts packages/gamut-styles: 274 tests pass.🤖 Generated with Claude Code