Skip to content

Conversation

@kounoike
Copy link

@kounoike kounoike commented Nov 9, 2023

#50 didn't fix #38.
because [[ "abc" == $pattern ]] is simple string match.
for regex match, should be [[ "abc" =~ $pattern ]].

this PR fix it.

this PR also fix document. ignore pattern is regex, NOT glob.

@khru khru mentioned this pull request Nov 9, 2023
@johnlk
Copy link
Contributor

johnlk commented Apr 15, 2024

This change takes the wildcard matching and switches us to regex matching. Both are acceptable options. As a point of opinion, wildcard matching feels more ergonomic.

If we did want to support regex matching, maybe this should be another param like regex_files_to_ignore?

@Chemaclass
Copy link
Contributor

I think regex_files_to_ignore would be a better option, as the current PR implementation breaks the backward compatibility with the existing projects who uses this tool.

See more: #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore files and folders by pattern?

3 participants