Repository navigation
Conversation
furtib
added
non-functional change ☮️
nettle
reviewed
Oct 9, 2026
| ], | ||
| local = True, | ||
| tags = ["unit"] + tags, | ||
| # Each test runs a nested Bazel invocation, so it needs a second |
Collaborator
There was a problem hiding this comment.
To be honest this does not sound reasonable so far.
| @@ -113,7 +113,13 @@ py_test( | |||
| data = [":report_files"], | |||
| local = True, | |||
| main = "store_check.py", | |||
Collaborator
There was a problem hiding this comment.
This is another question... What do we actually test in store_check.py?
| size = size, | ||
| tags = tags, | ||
| # Each test runs a nested Bazel invocation, so it needs a second | ||
| # thread. Declaring 2 CPUs makes Bazel reserve the capacity instead of |
Collaborator
There was a problem hiding this comment.
Then... why only 2 CPU? Not 3 or 4? 100?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Currently, the store tests are flaky.
This is because in them we start a CodeChecker server with a timeout of 10sec.
This normally wouldn't be an issue, but when competing for resources with other tests (that also might use more threads than their fair share), the CodeChecker server often times out, resulting in a test failure.
Tests that use bazel inside bazel calls are a notorious example of tests that take more than their fair share. (An extra Bazel server process.)
What:
cpu=2tag to store tests. -- This solved the flakiness.cpu=2tag to unit tests that use nested Bazel calls. -- This in some cases halved the length of tests. (In CI, external tests passed in 12-20 seconds instead of 40-60sec)Addresses:
none