Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/unit/caching/caching_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ def caching_test(
str(expected_action_count),
],
local = True,
tags = ["unit"] + tags,
# Each test runs a nested Bazel invocation, so it needs a second

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest this does not sound reasonable so far.

# thread. Declaring 2 CPUs makes Bazel reserve the capacity instead of
# overpacking the machine.
tags = ["unit", "cpu:2"] + tags,
size = size,
**kwargs
)
5 changes: 4 additions & 1 deletion test/unit/external_repository/external_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ def external_test(
# No other way to ensure integrated bazel can find the repository
local = True,
size = size,
tags = tags,
# Each test runs a nested Bazel invocation, so it needs a second
# thread. Declaring 2 CPUs makes Bazel reserve the capacity instead of

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then... why only 2 CPU? Not 3 or 4? 100?

# overpacking the machine.
tags = tags + ["cpu:2"],
**kwargs
)
16 changes: 14 additions & 2 deletions test/unit/parse/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,13 @@ py_test(
data = [":report_files"],
local = True,
main = "store_check.py",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another question... What do we actually test in store_check.py?

tags = ["unit"],
tags = [
# The store test runs a CodeChecker server alongside the store client.
# Running it alongside other tests often make this test fail
# due to the codechecker server timing out.
"cpu:2",
"unit",
],
deps = [":helpers"],
)

Expand Down Expand Up @@ -153,6 +159,12 @@ py_test(
data = [":per_file_report_files"],
local = True,
main = "store_check.py",
tags = ["unit"],
tags = [
# The store test runs a CodeChecker server alongside the store client.
# Running it alongside other tests often make this test fail
# due to the codechecker server timing out.
"cpu:2",
"unit",
],
deps = [":helpers"],
)
Loading