Repository navigation
test: Declare thread usage of tests, to fix flakiness and speedup #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
furtib
wants to merge
2
commits into
Ericsson:main
Choose a base branch
from
furtib:fix-too-flaky-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,6 +97,9 @@ def external_test( | |
| # No other way to ensure integrated bazel can find the repository | ||
| local = True, | ||
| size = size, | ||
| tags = tags, | ||
| # Each test runs a nested Bazel invocation, so it needs a second | ||
| # thread. Declaring 2 CPUs makes Bazel reserve the capacity instead of | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then... why only 2 CPU? Not 3 or 4? 100? |
||
| # overpacking the machine. | ||
| tags = tags + ["cpu:2"], | ||
| **kwargs | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,7 +113,13 @@ py_test( | |
| data = [":report_files"], | ||
| local = True, | ||
| main = "store_check.py", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is another question... What do we actually test in store_check.py? |
||
| tags = ["unit"], | ||
| tags = [ | ||
| # The store test runs a CodeChecker server alongside the store client. | ||
| # Running it alongside other tests often make this test fail | ||
| # due to the codechecker server timing out. | ||
| "cpu:2", | ||
| "unit", | ||
| ], | ||
| deps = [":helpers"], | ||
| ) | ||
|
|
||
|
|
@@ -153,6 +159,12 @@ py_test( | |
| data = [":per_file_report_files"], | ||
| local = True, | ||
| main = "store_check.py", | ||
| tags = ["unit"], | ||
| tags = [ | ||
| # The store test runs a CodeChecker server alongside the store client. | ||
| # Running it alongside other tests often make this test fail | ||
| # due to the codechecker server timing out. | ||
| "cpu:2", | ||
| "unit", | ||
| ], | ||
| deps = [":helpers"], | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest this does not sound reasonable so far.