Improve log message around interpreter attach/cleanup/destroy#943
Improve log message around interpreter attach/cleanup/destroy#943michael-o wants to merge 1 commit intoGrahamDumpleton:developfrom
Conversation
Improve log by saying whether a main interpreter is created or a named one (subinterpreter). This fixes GrahamDumpleton#942
fb4d4b8 to
7da40c4
Compare
| } | ||
| else { | ||
| ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server, | ||
| "mod_wsgi (pid=%d): Destroy main interpreter.", |
There was a problem hiding this comment.
I am not 100% whether destroy is also subject to main/sub handling.
|
The distinction that it is a sub interpreter is actually meaningful as many people using Python don't even realise there are sub interpreters. I will need to check logging elsewhere bit maybe then should be: and: Sub interpreters hang off the main interpreter so language just needs to be different. |
Yes, please do. My point is that there a too many places logging about subinterpreters (named ones), ideally this would be consistently. I cannot tell for certain which other statements need to aligned as well. |
Improve log by saying whether a main interpreter is created or a named one (subinterpreter).
Output:
I intentionally haven't used the term subinterpreter because it would have been inconsistent with the rest of the log message. It needs to be done consistently throughout.
This fixes #942.