Skip to content

Improve log message around interpreter attach/cleanup/destroy #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michael-o wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve log message around interpreter attach/cleanup/destroy #943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions src/server/wsgi_interp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,10 +463,16 @@ InterpreterObject *newInterpreterObject(const char *name)
* be the case for the main Python interpreter.
*/

ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Attach interpreter '%s'.",
getpid(), name);

if (*name) {
ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Attach interpreter '%s'.",
getpid(), name);
}
else {
ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Attach main interpreter.",
getpid());
}
self->interp = interp;
self->owner = 0;

Expand Down Expand Up @@ -1606,16 +1612,30 @@ static void Interpreter_dealloc(InterpreterObject *self)

if (self->owner) {
Py_BEGIN_ALLOW_THREADS
ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Destroy interpreter '%s'.",
getpid(), self->name);
if (*self->name) {
ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Destroy interpreter '%s'.",
getpid(), self->name);
}
else {
ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Destroy main interpreter.",
Copy link
Contributor Author

@michael-o michael-o Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% whether destroy is also subject to main/sub handling.

getpid());
}
Py_END_ALLOW_THREADS
}
else {
Py_BEGIN_ALLOW_THREADS
ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Cleanup interpreter '%s'.",
getpid(), self->name);
if (*self->name) {
ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Cleanup interpreter '%s'.",
getpid(), self->name);
}
else {
ap_log_error(APLOG_MARK, APLOG_INFO, 0, wsgi_server,
"mod_wsgi (pid=%d): Cleanup main interpreter.",
getpid());
}
Py_END_ALLOW_THREADS
}

Expand Down