Repository navigation
👷 QD-16987 Build arm64 base images on native runners instead of QEMU - #1137
Merged
Merged
Conversation
QEMU-emulated arm64 builds on ubuntu-latest are slow and intermittently crash Node/V8 with SIGILL (exit code 132). - Build each bake group per platform: amd64 on ubuntu-latest, arm64 on ubuntu-24.04-arm; drop setup-qemu - On push, push untagged images by digest (a tagged ref can't be pushed by digest), then the merge job creates the multi-arch tags from docker-bake.hcl via `docker buildx imagetools create` - Use a separate GHA cache scope per group and platform instead of one shared "provenance" scope overwritten by all jobs
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Qodana for Go127 new problems were found
@@ Code coverage @@
+ 65% total lines covered
10631 lines analyzed, 6980 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
… in Python - docker-bake.hcl: BASE_PLATFORMS / PUSH_BY_DIGEST variables and a tags() function replace the jq bake override (based on the patch from review) - matrix platform as objects instead of include - group list shared via YAML anchor, comments restored, groups job removed - merge logic moved to .github/scripts/merge-base-images.py; validates the whole group before tagging, so tags are never partially updated
Andrei Iurko (AndreiIurko)
approved these changes
Nov 12, 2026
This was referenced Nov 13, 2026
Contributor
|
Successfully created backport PR for |
Ivan Efimov (ivanovec)
added a commit
that referenced
this pull request
Nov 13, 2026
…1137) (#1143) * 👷 QD-16987 Build arm64 base images on native runners instead of QEMU QEMU-emulated arm64 builds on ubuntu-latest are slow and intermittently crash Node/V8 with SIGILL (exit code 132). - Build each bake group per platform: amd64 on ubuntu-latest, arm64 on ubuntu-24.04-arm; drop setup-qemu - On push, push untagged images by digest (a tagged ref can't be pushed by digest), then the merge job creates the multi-arch tags from docker-bake.hcl via `docker buildx imagetools create` - Use a separate GHA cache scope per group and platform instead of one shared "provenance" scope overwritten by all jobs * 👷 QD-16987 Address review: push mode in docker-bake.hcl, merge script in Python - docker-bake.hcl: BASE_PLATFORMS / PUSH_BY_DIGEST variables and a tags() function replace the jq bake override (based on the patch from review) - matrix platform as objects instead of include - group list shared via YAML anchor, comments restored, groups job removed - merge logic moved to .github/scripts/merge-base-images.py; validates the whole group before tagging, so tags are never partially updated (cherry picked from commit f603f9a) Co-authored-by: Ivan Efimov <ivan.efimov@jetbrains.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Build arm64 base images on native GitHub arm64 runners instead of QEMU emulation.
linux/amd64onubuntu-latest,linux/arm64onubuntu-24.04-arm.setup-qemuis removed.push, every target is pushed untagged by digest (a tagged ref can't be pushed by digest), using a generated bake override: tags are cleared andoutputgetsname=<repository of the target's first tag>. Nothing is hardcoded — tags and repositories still come fromdocker-bake.hcl.merge (<group>)job reads the tags viadocker buildx bake --print, the per-platform digests from the bake metadata artifacts, and creates the multi-arch tags withdocker buildx imagetools create. A group whose platform build is missing fails on its own; other groups are still merged.base-<group>-<arch>) instead of the singleprovenancescope that all 13 jobs overwrote.Behavior changes
base (jvm)→base (jvm, amd64)/base (jvm, arm64)+merge (jvm). Not part of required status checks.Unchanged
TARGETPLATFORM/dpkg --print-architecture, noBUILDPLATFORM).imagetools create).pushevents; PRs build both platforms without pushing.To watch on the first runs
mode=max(may cause LRU eviction → slower builds, not failures).ubuntu-24.04-arm(only one platform per runner now).Related Issue
QD-16987
Motivation and Context
QEMU-emulated arm64 builds are slow and intermittently crash Node/V8 with SIGILL, e.g. https://github.com/JetBrains/qodana-cli/actions/runs/43056082577/job/130645796321:
The same step passes on re-run.
ci.ymlalready usesubuntu-24.04-arm.How Has This Been Tested
actionlint1.7.7 (with shellcheck): clean.docker buildx bake --printwith the generated override for all 13 groups (26 targets): push mode → tags cleared, single platform, output toregistry.jetbrains.team/p/sa/containers/qodanaby digest; PR mode → tags kept, no output.contexts, separate amd64/arm64 builds pushed by digest, then the merge step extracted verbatim from the workflow → each tag (incl. multiple tags per target) points to an index withlinux/amd64+linux/arm64+ attestation manifests; a missing platform fails the merge with exit 1.push, so it will be exercised after merge tomain.Types of changes