Remove dead code from DRF #302
Conversation
| from resonant_settings.django_extensions import * | ||
| from resonant_settings.logging import * | ||
| from resonant_settings.oauth_toolkit import * | ||
| from resonant_settings.rest_framework import * |
There was a problem hiding this comment.
While most of this file isn't needed, it does also configure some Django-specific settings which relate to authentication and security.
How does BatAI authenticate API requests currently (cookies, OAuth2, etc.)? Do you use the same authentication for both the Ajax requests from the SPA and for using the Swagger docs (or do you not use the Swagger docs at all)? I want to make sure Ninja stays configured appropriately and securely.
There was a problem hiding this comment.
Sorry, I thought I had replied to this already (must not have submitted).
The BatAI client uses Oauth for API Requests.
We don't use the Swagger docs but use the Ninja Api Docs. Those seem to use the same authentication as the django admin which looks like a cookies.
This is currently causing import errors in `urls.py`.
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Got around to testing this and everything I checked seems to work properly.
All this seems to be leftover stuff before I swapped to using ninja for everything.
This was good because it led to be testing and looking at some client code.
I did a check of the client side code for the api and realized there are some references to proccessing-task and processing-task/filtered that don't have endpoints. I created an issue for it here: #306
Otherwise I think this is good to merge in.
2 participants
This is currently causing import errors in
urls.py.