Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions bats_ai/core/rest/__init__.py

This file was deleted.

17 changes: 0 additions & 17 deletions bats_ai/core/rest/compressed_spectrogram.py

This file was deleted.

13 changes: 0 additions & 13 deletions bats_ai/core/rest/nabat/__init__.py

This file was deleted.

17 changes: 0 additions & 17 deletions bats_ai/core/rest/nabat/nabat_compressed_spectrogram.py

This file was deleted.

17 changes: 0 additions & 17 deletions bats_ai/core/rest/nabat/nabat_spectrogram.py

This file was deleted.

17 changes: 0 additions & 17 deletions bats_ai/core/rest/spectrogram.py

This file was deleted.

1 change: 0 additions & 1 deletion bats_ai/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from resonant_settings.django_extensions import *
from resonant_settings.logging import *
from resonant_settings.oauth_toolkit import *
from resonant_settings.rest_framework import *
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While most of this file isn't needed, it does also configure some Django-specific settings which relate to authentication and security.

How does BatAI authenticate API requests currently (cookies, OAuth2, etc.)? Do you use the same authentication for both the Ajax requests from the SPA and for using the Swagger docs (or do you not use the Swagger docs at all)? I want to make sure Ninja stays configured appropriately and securely.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I had replied to this already (must not have submitted).
The BatAI client uses Oauth for API Requests.
We don't use the Swagger docs but use the Ninja Api Docs. Those seem to use the same authentication as the django admin which looks like a cookies.


django_stubs_ext.monkeypatch()

Expand Down
3 changes: 0 additions & 3 deletions bats_ai/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,13 @@
from django.contrib import admin
from django.urls import include, path

from bats_ai.core.rest import rest

from .api import api

base_urlpatterns = [
path('accounts/', include('allauth.urls')),
path('oauth/', include('oauth2_provider.urls')),
path('admin/', admin.site.urls),
path('api/v1/s3-upload/', include('s3_file_field.urls')),
path('api/v1/dynamic/', include(rest.urls)),
path('api/v1/', api.urls),
]

Expand Down