-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: copy updates to messages.json #37810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Made small copy tweaks around case consistency and grammar
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
|
Submitting this as is since it is simple copy tweaks. @georgewrmarshall -- let me know if you need me to fill this out more in the future! |
georgewrmarshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on your first PR! These changes look great! We should likely also make them in the British English file too 🙏 app/_locales/en_GB/messages.json
Adding same edits to GB EN file!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! LGTM 🚀 I've updated the PR to make linting and unit tests pass. Left one question regarding my knowledge of our content guidelines 🙏
| }, | ||
| "confirmTitleDescDelegationUpgrade": { | ||
| "message": "You're switching to a smart account" | ||
| "message": "You're switching to a smart account." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression we should only use a period for multiple lines of content or when a comma is present. But I just read the updated docs — it looks like the guidance now is to use a period for any complete sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly!
Description
Various content updates based on our content guidelines
Changelog
CHANGELOG entry: N/A
Related issues
Fixes: N/A
Manual testing steps
Only made copy updates.
Screenshots/Recordings
Before
NAAfter
NAPre-merge author checklist
Pre-merge reviewer checklist
Note
Refines grammar/punctuation in en/en_GB locale strings and updates related tests/snapshots to match.
app/_locales/en/messages.jsonandapp/_locales/en_GB/messages.json(e.g.,All-time high/low, remove trailing punctuation in some labels, lowercase "Price impact" tooltip title, add period to smart account switch description, capitalize URL in NFT disclaimer, remove exclamation in install complete, normalize "Learn more").account-modal-account-type-change.spec.ts.Written by Cursor Bugbot for commit 477c5ac. This will update automatically on new commits. Configure here.