Skip to content

Conversation

@alidotforrest
Copy link
Contributor

@alidotforrest alidotforrest commented Nov 13, 2025

Description

Various content updates based on our content guidelines

Open in GitHub Codespaces

Changelog

CHANGELOG entry: N/A

Related issues

Fixes: N/A

Manual testing steps

Only made copy updates.

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refines grammar/punctuation in en/en_GB locale strings and updates related tests/snapshots to match.

  • i18n (copy tweaks)
    • Standardize phrasing and punctuation in app/_locales/en/messages.json and app/_locales/en_GB/messages.json (e.g., All-time high/low, remove trailing punctuation in some labels, lowercase "Price impact" tooltip title, add period to smart account switch description, capitalize URL in NFT disclaimer, remove exclamation in install complete, normalize "Learn more").
  • Tests
    • Adjust e2e expectation for smart account upgrade text in account-modal-account-type-change.spec.ts.
    • Update confirmation title test to expect period in smart account switch description.
    • Refresh snapshots for NFT details disclaimer and onboarding create-password link text.

Written by Cursor Bugbot for commit 477c5ac. This will update automatically on new commits. Configure here.

Made small copy tweaks around case consistency and grammar
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@alidotforrest
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@alidotforrest
Copy link
Contributor Author

Submitting this as is since it is simple copy tweaks. @georgewrmarshall -- let me know if you need me to fill this out more in the future!

@alidotforrest alidotforrest marked this pull request as ready for review November 14, 2025 19:50
@georgewrmarshall georgewrmarshall changed the title copy updates to messages.json chore: copy updates to messages.json Nov 14, 2025
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on your first PR! These changes look great! We should likely also make them in the British English file too 🙏 app/_locales/en_GB/messages.json

@alidotforrest alidotforrest marked this pull request as draft November 17, 2025 18:13
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! LGTM 🚀 I've updated the PR to make linting and unit tests pass. Left one question regarding my knowledge of our content guidelines 🙏

},
"confirmTitleDescDelegationUpgrade": {
"message": "You're switching to a smart account"
"message": "You're switching to a smart account."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression we should only use a period for multiple lines of content or when a comma is present. But I just read the updated docs — it looks like the guidance now is to use a period for any complete sentence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly!

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Nov 24, 2025
@georgewrmarshall georgewrmarshall marked this pull request as ready for review November 24, 2025 00:13
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 24, 2025 00:13
@georgewrmarshall georgewrmarshall added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 24, 2025
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 24, 2025 00:38
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 25, 2025 00:37
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Nov 25, 2025
Merged via the queue into MetaMask:main with commit 12487f7 Nov 25, 2025
165 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

external-contributor no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants