-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(SDKConnectV2): add toasts for non-success states #22610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+99
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaeb7bc to
84e13af
Compare
|
wenfix
approved these changes
Nov 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.61.0
Issue or pull request that will be included in release 7.61.0
size-M
team-wallet-integrations
Wallet Integrations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
This PR adds to the current implementation of MetaMask Connect toasts to ensure that error messages are displayed in the Wallet when a user rejects a request or when other errors occur during the request lifecycle.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-825
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-11-13.at.11.22.04.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Show an error toast when bridge responses contain JSON-RPC errors and use the connection id for error notifications; add tests for success/error paths.
services/connection.ts): On bridgeresponse, detect JSON-RPC errors (errorin payload) and callhostApp.showConnectionError(this.info); otherwise callshowReturnToApp(this.info). Always forward payload to client.adapters/host-application-adapter.ts): ChangeshowConnectionErrorsignature toconninfo?and useconninfo.idwhen provided (fallback to timestamp).types/host-application-adapter.ts): Update interface forshowConnectionError(conninfo?)and clarify return-to-app success doc.iddon’t trigger return-to-app.Written by Cursor Bugbot for commit 803a6b5. This will update automatically on new commits. Configure here.