feat: Propagate license ID across feeds sharing the same license URL#1668
Open
davidgamez wants to merge 11 commits intomainfrom
Open
feat: Propagate license ID across feeds sharing the same license URL#1668davidgamez wants to merge 11 commits intomainfrom
davidgamez wants to merge 11 commits intomainfrom
Conversation
Collaborator
|
Shiny! What is the workflow of this change @davidgamez? Say in Retool we insert the same license URL into a feed, and the URL matches 3 other feeds. What needs to happen for the propagation to take place? |
Member
Author
You just need to select the checkbox to propagate the license |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary:
This pull request introduces a new feature for propagating license IDs to multiple feeds that share the same normalized license URL, along with supporting API documentation and implementation changes. Additionally, it updates the OpenAPI schema to support this functionality and adds new request/response models for the API. There are also minor documentation improvements and cleanup of hash descriptions in the API schema.
License Propagation Feature:
propagate_license_by_urlinlicense_utils.pyto propagate a license ID to all non-deprecated GTFS/GTFS-RT feeds sharing the same normalized license URL, with support for dry-run and override modes. The function returns a detailed result describing affected feeds.feeds_operations_impl.py. Whenpropagate_licenseis set to true in the request, the license ID is propagated to all matching feeds after creation or update. [1] [2] [3]API and OpenAPI Documentation:
/v1/operations/licenses:propagate_matchto trigger license propagation, with new request and response schemas (PropagateLicenseRequest,PropagateLicenseResponse,PropagateLicenseAffectedFeed). [1] [2]propagate_licenseboolean property, allowing clients to request license propagation as part of those operations. [1] [2] [3] [4]Supporting Code and Models:
Documentation and Schema Cleanup:
Minor Documentation Enhancements:
These changes collectively enable operators to easily propagate license information across multiple feeds with a single action, improving data consistency and reducing manual updates.
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Testing tips:
Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything