-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Propagate license ID across feeds sharing the same license URL #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidgamez
wants to merge
11
commits into
main
Choose a base branch
from
feat_propagate_license_id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f212de3
implement license propagate
davidgamez 3c6ce62
add missing test
davidgamez 793b862
Merge branch 'main' into feat_propagate_license_id
davidgamez b816fb6
remove deprecated and data type filters
davidgamez 928ffc6
filtering out the unpublished feeds
davidgamez f7fdcca
Merge branch 'main' into feat_propagate_license_id
davidgamez 194f439
update schema with main
davidgamez 0c13dfc
fix failing tests
davidgamez dc9008b
add gbfs data type
davidgamez 35ecbda
add init script
davidgamez f4a4a17
Merge branch 'main' into feat_propagate_license_id
davidgamez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should consider adding a 400 response here, since it can be sent back here:
mobility-feed-api/functions-python/operations_api/src/feeds_operations/impl/licenses_api_impl.py
Line 220 in f4a4a17
(thanks copilot)