Skip to content

refactor(pii): type NER payload and runtime boundaries#613

Draft
binaryaaron wants to merge 3 commits into
binaryaaron/pr596-05-typecheck-toolsfrom
binaryaaron/pr596-06-typecheck-pii
Draft

refactor(pii): type NER payload and runtime boundaries#613
binaryaaron wants to merge 3 commits into
binaryaaron/pr596-05-typecheck-toolsfrom
binaryaaron/pr596-06-typecheck-pii

Conversation

@binaryaaron

@binaryaaron binaryaaron commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds typed NER API payloads and normalizes metadata serialization.
  • Removes the PII replacer exclusion from ty checks.
  • Types NER model, metadata, regex, and data-editor runtime boundaries.

Test plan

  • mise run test -- tests/pii_replacer tests/data_processing/records/test_fragment.py
  • mise run typecheck

Closes #614

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0d481dbc-5e97-4d5c-aece-ee6f37fc2161

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch binaryaaron/pr596-06-typecheck-pii

Comment @coderabbitai help to get the list of available commands.

@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from 75ff152 to 1e74819 Compare June 24, 2026 18:11
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from c227483 to 6029bd9 Compare June 24, 2026 18:11
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from 1e74819 to 670ffdd Compare June 24, 2026 18:18
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from 6029bd9 to 58a6452 Compare June 24, 2026 18:18
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from 670ffdd to 8762112 Compare June 24, 2026 18:23
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from 58a6452 to b0f86b7 Compare June 24, 2026 18:23
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from 8762112 to 9c96037 Compare June 24, 2026 18:31
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from b0f86b7 to a1f13f1 Compare June 24, 2026 18:31
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from 9c96037 to 8d55e69 Compare June 24, 2026 21:46
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from 575d633 to e62f16e Compare June 24, 2026 21:46
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from 8d55e69 to 97c3d20 Compare June 24, 2026 22:16
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from e62f16e to 34fef1c Compare June 24, 2026 22:16
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from 97c3d20 to b0fc400 Compare June 26, 2026 21:04
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch 2 times, most recently from 79630e5 to 4066f36 Compare June 30, 2026 21:40
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch 2 times, most recently from 3ca326f to ab75d47 Compare July 6, 2026 18:07
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from 4066f36 to 65714d9 Compare July 6, 2026 18:07
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from ab75d47 to ae3cfb7 Compare July 6, 2026 19:27
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from 65714d9 to e6f0103 Compare July 6, 2026 19:28
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from ae3cfb7 to f99a9d9 Compare July 8, 2026 16:05
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from e6f0103 to 9786d6a Compare July 8, 2026 16:05
@binaryaaron binaryaaron changed the title refactor(pii): type runtime NER boundaries refactor(pii): type NER payload and runtime boundaries Jul 8, 2026
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from f99a9d9 to 148fa85 Compare July 9, 2026 17:44
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from 9786d6a to 2302d50 Compare July 9, 2026 17:44
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-05-typecheck-tools branch from 148fa85 to a5f72a0 Compare July 10, 2026 21:33
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
@binaryaaron binaryaaron force-pushed the binaryaaron/pr596-06-typecheck-pii branch from 2302d50 to dbd913b Compare July 10, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant