ci: scaffold unified nightly and stable release workflow#623
Conversation
|
177e61f to
d0127e6
Compare
Signed-off-by: Swarom Muley <smuley@nvidia.com>
Signed-off-by: Swarom Muley <smuley@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Swarom Muley <smuley@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
2fe7357 to
399e17d
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe release process is consolidated into ChangesRelease pipeline
Build and local workflow support
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yaml:
- Around line 702-705: Update the “Report packaged Helm chart” step to pass the
package output through the step’s env mapping, then reference that environment
variable in the shell command instead of directly expanding
steps.package.outputs.chart_package in run.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f033b4c6-ba65-40c8-80f1-29d0efe65bf9
📒 Files selected for processing (9)
.github/scripts/write_release_bundle_metadata.py.github/workflows/ngc-metadata.yaml.github/workflows/release-bundle.yaml.github/workflows/release-nightly.yaml.github/workflows/release-rc.yaml.github/workflows/release-stable.yaml.github/workflows/release.yaml.gitignoretests/unit/release/test_write_release_bundle_metadata.py
💤 Files with no reviewable changes (6)
- .github/workflows/release-rc.yaml
- .github/workflows/release-nightly.yaml
- tests/unit/release/test_write_release_bundle_metadata.py
- .github/workflows/release-bundle.yaml
- .github/scripts/write_release_bundle_metadata.py
- .github/workflows/release-stable.yaml
|
@crookedstorm can we also delete https://github.com/NVIDIA-NeMo/nemo-platform/blob/main/release/assets.yaml and delete/update https://github.com/NVIDIA-NeMo/nemo-platform/blob/main/RELEASING.md? |
Signed-off-by: Brooke Storm <brookes@nvidia.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
RELEASING.md (1)
141-153: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMissing "Next Steps" section.
Doc ends without cross-links to related docs (e.g. release.yaml, CONTRIBUTING). As per coding guidelines, "Include 'Next Steps' section at the end with cross-links to related documentation content."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@RELEASING.md` around lines 141 - 153, Add a “Next Steps” section at the end of RELEASING.md after the completed-release verification content, including links to the related release workflow documentation (release.yaml) and CONTRIBUTING guidance.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@RELEASING.md`:
- Around line 141-153: Add a “Next Steps” section at the end of RELEASING.md
after the completed-release verification content, including links to the related
release workflow documentation (release.yaml) and CONTRIBUTING guidance.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 38d174d9-1689-482f-8192-ec2dafd9f684
📒 Files selected for processing (3)
.github/workflows/release.yamlRELEASING.mdrelease/assets.yaml
💤 Files with no reviewable changes (1)
- release/assets.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/release.yaml
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
Signed-off-by: Brooke Storm <brookes@nvidia.com>
This replaces the separate nightly, RC, stable, and release-bundle workflows with one workflow for nightly and stable releases. Each run resolves an exact source commit and selected artifact set, optionally synchronizes NGC metadata, starts only the selected staging work, waits for the artifacts to reach their final locations, and reports the result. Stable releases also dispatch artifact registration, and full
allreleases create a GitHub Release. The legacy workflows, release-bundle metadata helper, and its tests are removed.Linear: AIREINF-254 — Adapt Release Workflow by Newer Design
Stable and nightly behavior
MAJOR.MINOR.PATCHversion.nightly-YYYYMMDDHHMMSS.all,wheels,containers,helm, or a custom set of IDs.all.k8s/helmusing the release version and publishes it to NGC.allrelease.Dry runs resolve and validate the release plan and package Helm when selected, but skip publishing, downstream release dispatches, final-location polling, GitHub Release creation, and deployment creation.
Artifact catalog
nemo-platform,nemo-platform-pluginnmp-api,nmp-core,nmp-cpu-tasks,nmp-automodel-tasks,nmp-automodel-training,nmp-unsloth-training,auditor-tasks,safe-synthesizer-tasksnemo-platformfromk8s/helmDispatch contracts
stage-wheelsref,cadence,release_label,nightly_timestamp,wheelsreleaseref,version,containersregister-release-artifactsversion,source_sha,source_run_url,wheel_ids,container_ids,helm_idcreate-release-deploymentref,cadence,release_label,helm_versionHelm staging runs directly in this workflow and does not use a repository dispatch. For custom stable releases, unselected ID arrays are empty and
helm_idisnull.Before merge
Configure the
SLACK_ALERTS_WEBHOOKandSLACK_RELEASE_WEBHOOKActions secrets used by the notification jobs.Summary by CodeRabbit
release.yamlworkflow for nightly and stable releases, including artifact selection, validation, optional NGC metadata sync, Helm packaging/publishing, polling/verification, and Slack notifications (with dry-run).nmp-core.RELEASING.mdto reflect the new release flow..gitignorefor local Nektos Act files; improved kind pre-pulling and adjusted docker build targets.