Skip to content

chore: shim fix for automodel - #697

Closed
mckornfield wants to merge 1 commit into
mainfrom
fix-automodel-build/mck
Closed

chore: shim fix for automodel#697
mckornfield wants to merge 1 commit into
mainfrom
fix-automodel-build/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved Automodel container builds by narrowing dependency installation to the Automodel package only, reducing unnecessary components.
    • Reduced the platform workspace scope to include only the elements needed for Automodel tasks.
    • Updated the Automodel uv workspace configuration to exclude model-service inputs while keeping the required Automodel-related packages available for builds.

@mckornfield
mckornfield requested review from a team as code owners July 15, 2026 14:21
@github-actions github-actions Bot added the chore label Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1ba2fba3-28c5-43ff-9dcb-63c091f783e9

📥 Commits

Reviewing files that changed from the base of the PR and between 534a9da and ee54b96.

📒 Files selected for processing (3)
  • docker/automodel/Dockerfile.nmp-automodel-tasks
  • docker/automodel/Dockerfile.platform-workspace
  • docker/automodel/pyproject.workspace.toml
💤 Files with no reviewable changes (1)
  • docker/automodel/pyproject.workspace.toml
🚧 Files skipped from review as they are similar to previous changes (2)
  • docker/automodel/Dockerfile.platform-workspace
  • docker/automodel/Dockerfile.nmp-automodel-tasks

📝 Walkthrough

Walkthrough

The automodel Docker build now uses a reduced uv workspace and build context, while installing services/core/models separately in the tasks image.

Changes

Automodel build configuration

Layer / File(s) Summary
Reduce automodel workspace scope
docker/automodel/pyproject.workspace.toml, docker/automodel/Dockerfile.platform-workspace
The workspace and copied build context exclude the models packages while retaining automodel-related packages.
Separate models installation
docker/automodel/Dockerfile.nmp-automodel-tasks
The runtime stage syncs only nmp-automodel into the configured virtual environment, then installs services/core/models separately in editable mode.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to automodel, but "shim fix" is too vague to clearly describe the Docker/workspace build changes. Rename it to state the main change, e.g. "chore: fix automodel Docker build workspace scope".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-automodel-build/mck

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 25439/32661 77.9% 62.5%
Integration Tests 14703/31310 47.0% 19.3%

* use pip install -e and copy in only the
shared model code

Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant