Skip to content

fix(bmc-explorer): pick the manager whose ManagerForServers links the explored system - #5512

Open
shevchenko-evgeny wants to merge 1 commit into
NVIDIA:release/v2.1from
shevchenko-evgeny:fix/bmc-explorer-manager-selection
Open

fix(bmc-explorer): pick the manager whose ManagerForServers links the explored system#5512
shevchenko-evgeny wants to merge 1 commit into
NVIDIA:release/v2.1from
shevchenko-evgeny:fix/bmc-explorer-manager-selection

Conversation

@shevchenko-evgeny

Copy link
Copy Markdown
Contributor

When exploring a BMC, nv_generate_exploration_report picks one ComputerSystem and one Manager, and the resulting EndpointExplorationReport pairs them as if they described the same machine. The system side is already careful: it skips
past the first member to prefer a system that actually exposes BIOS. The manager side was not — it unconditionally took managers[0].

Related issues

Add support for Supermicro GB300 NVL
Add support for PowerEdge XE9780

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

… explored system

Signed-off-by: Evgeny Shevchenko <eshevchenko@mirantis.com>
@shevchenko-evgeny
shevchenko-evgeny requested a review from a team August 28, 2026 13:08
@copy-pr-bot

copy-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4f1880b4-aef3-46e7-ae27-aa7859b77401

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant