Skip to content

fix(bmc-explorer): pick the manager whose ManagerForServers links the explored system #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shevchenko-evgeny wants to merge 1 commit into
base: release/v2.1
Choose a base branch
from
Open

fix(bmc-explorer): pick the manager whose ManagerForServers links the explored system #5512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions crates/bmc-explorer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,17 +149,31 @@ pub async fn nv_generate_exploration_report<B: Bmc>(
let other_system_with_bios = systems_iter.find(|system| system.raw().bios.is_some());
let system = other_system_with_bios.unwrap_or(first_system);

let manager = root
let mut managers = root
.managers()
.await
.map_err(Error::nv_redfish("managers"))?
.ok_or_else(Error::bmc_not_provided("managers"))?
.members()
.await
.map_err(Error::nv_redfish("managers members"))?
.into_iter()
.next()
.ok_or_else(Error::bmc_not_provided("at least one manager"))?;
.map_err(Error::nv_redfish("managers members"))?;

// Prefer the manager that controls the chosen system — Fall back to
// the first manager for BMCs.

let manager = match managers.iter().position(|m| {
m.raw()
.links
.as_ref()
.and_then(|l| l.manager_for_servers.as_ref())
.is_some_and(|servers| servers.iter().any(|s| s.id() == system.odata_id()))
}) {
Some(i) => managers.swap_remove(i),
None => managers
.into_iter()
.next()
.ok_or_else(Error::bmc_not_provided("at least one manager"))?,
};

let is_bluefield_system = is_bluefield_system_id(system.id());
let system_explore_config = computer_system::Config {
Expand Down