fix: pull in additional PNs to GB200xBF3 mlxconfig profile - #5544
Conversation
GB200 B3240 devices can report `PN0` in bootstrap Redfish data and `P_Ax` after Scout records the device identity. Neither value was in the exact selector, so both provisioning paths could retain the generic BF3 profile on matching GB200 racks. Accept both values through the shared selector while preserving the separate GB200 rack check and rejecting other B3240 prefixes. This supports NVIDIA#5541 Signed-off-by: Chet Nichols III <chetn@nvidia.com>
|
@coderabbitai full_review, thanks! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. Summary by CodeRabbit
WalkthroughThe NVConfig selector now accepts two additional GB200/B3240 part numbers. Documentation and table-driven tests reflect the expanded identity set. ChangesGB200 B3240 identity support
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change expands GB200 device matching for the intended identities without altering the existing rack check or provisioning assignments. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes address issue ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🐇🔍 ✅ Action performedFull review finished. |
…5547) This backports #5544 to v2.1. GB200 B3240 DPUs can report `900-9D3B6-00CN-PN0` in bootstrap Redfish data and `900-9D3B6-00CN-P_Ax` after Scout records the device identity. The v2.1 selector does not accept either value, so DPF and Non-DPF provisioning can select the generic BF3 profile for those devices even when the rack is identified as GB200. This adds both exact identities to the shared GB200 B3240 selector. The separate GB200 rack check remains required, and other B3240 prefixes remain rejected. The v2.1 integration tests still invoke `grpcurl`. #5386 removed it from `main`'s build containers, so release checks that do not rebuild a base container pull `latest` and fail before the integration tests start. This also makes the v2.1 workflow use its existing `v2.1-latest` x86_64 and aarch64 build container tags when those containers are not rebuilt. ## Related issues - Closes #5545 - Backports #5544 - Builds on #5482 and #5506 - Accounts for #5386 - Part of #5029 ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] **This PR contains breaking changes** ## Testing - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) - `cargo test -p carbide-libmlx-model` - `cargo make clippy` - `cargo make format-nightly` - `cargo carbide-lints --all-targets --all-features` - `git diff --check` ## Additional Notes The existing v2.1 DPF and Non-DPF integrations already consume this shared selector, so this PR does not change their NVConfig assignments. The `v2.1-latest` build container tags were published from the v2.1 Dockerfiles, which still install `grpcurl`. A Dockerfile change still selects the versioned container produced by that CI run. Mirrors continue using the `latest` tag from their configured source registry. --------- Signed-off-by: Chet Nichols III <chetn@nvidia.com>
GB200 B3240 DPUs can report
900-9D3B6-00CN-PN0in bootstrap Redfish data and900-9D3B6-00CN-P_Axafter Scout records the device identity. The shared selector did not accept either value, so DPF and Non-DPF provisioning selected the generic BF3 profile for those devices even when the rack was identified as GB200.This adds both exact identities to the shared GB200 B3240 selector. The separate GB200 rack check remains required, and other B3240 prefixes remain rejected.
Related issues
Type of Change
Breaking Changes
Testing
Unit tests added/updated
Integration tests added/updated
Manual testing performed
No testing required (docs, internal refactor, etc.)
cargo test -p carbide-libmlx-modelcargo make clippycargo make format-nightlygit diff --checkAdditional Notes
The existing DPF and Non-DPF integrations already consume this shared selector, so this PR does not change their NVConfig assignments.
The expanded local Carbide lints run (
--all-targets --all-features) reaches existingtxn_held_across_awaitfailures in unchangedcrates/api-core/tests/integration/dns_resolution.rs; that file is identical toorigin/main. The hosted lint task does not compile that integration target.