Raise clear error when uprating year is outside table range#352
Merged
Raise clear error when uprating year is outside table range#352
Conversation
Contributor
Author
|
Self-review: APPROVE. See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policyengine_uk_data/utils/uprating.pyuses a hardcodedEND_YEAR = 2034but bothuprate_valuesanduprate_datasetaccepted anytarget_year(orstart_year/end_year) without validation. Requesting a year past 2034 surfaced as a bare pandasKeyErrordeep in the call stack; requesting a year before 2020 silently read non-existent columns.This PR adds a typed
UpratingYearOutOfRangeErrorand validates every year argument at the top ofuprate_valuesanduprate_dataset. The error message tells the caller to either regenerate the table with a laterEND_YEARor pick a supported year.No signature changes beyond adding a typed exception class in the module namespace.
Test plan
uv run pytest policyengine_uk_data/tests/test_uprating_range.py -qpasses (rejects year above end, year below start, and accepts a supported year using a seeded tmp_path table).Finding U5 from the bug hunt.