Skip to content

[Comgr][hotswap] Reject transpiler builds against libLLVM - #3869

Open
martin-luecke wants to merge 1 commit into
amd-stagingfrom
users/mluecke/hotswap-reject-dylib-linkage
Open

[Comgr][hotswap] Reject transpiler builds against libLLVM#3869
martin-luecke wants to merge 1 commit into
amd-stagingfrom
users/mluecke/hotswap-reject-dylib-linkage

Conversation

@martin-luecke

Copy link
Copy Markdown

The Hotswap transpiler uses AMDGPU backend-private helpers that libLLVM.so does not export. Reject the unsupported configuration at CMake time instead of failing the final amd_comgr link.

Supporting this mode requires a complete static LLVM/Clang/LLD closure for COMGR without a transitive libLLVM.so dependency (#2927).

Stacked on #3807.

@github-actions github-actions Bot added the comgr Related to Code Object Manager label Aug 12, 2026
@martin-luecke
martin-luecke marked this pull request as ready for review August 12, 2026 09:07
@martin-luecke
martin-luecke requested a review from tgymnich August 12, 2026 09:07
@martin-luecke
martin-luecke force-pushed the users/ftynse/hotswap-m0-05-dylib-amdgpu-utils branch from 8f48588 to 93e827d Compare August 12, 2026 14:58
@martin-luecke
martin-luecke force-pushed the users/mluecke/hotswap-reject-dylib-linkage branch from c1f051e to 5a4292a Compare August 12, 2026 15:43
An error occurred while trying to automatically change base from users/ftynse/hotswap-m0-05-dylib-amdgpu-utils to amd-staging August 12, 2026 20:49
@martin-luecke
martin-luecke changed the base branch from users/ftynse/hotswap-m0-05-dylib-amdgpu-utils to amd-staging August 12, 2026 20:53
The transpiler depends on AMDGPU backend-private helpers that libLLVM does not
export. Reject monolithic LLVM or Clang linkage before COMGR_STATIC_LLVM
overrides the incoming consumer mode.
@martin-luecke
martin-luecke force-pushed the users/mluecke/hotswap-reject-dylib-linkage branch from 5a4292a to d2515b5 Compare August 12, 2026 21:31
@martin-luecke
martin-luecke enabled auto-merge (squash) August 12, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comgr Related to Code Object Manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants