fix(rccl): Fix clang_rt search for asan per-target-runtime-dir - #9739
Open
estewart08 wants to merge 1 commit into
Open
fix(rccl): Fix clang_rt search for asan per-target-runtime-dir#9739estewart08 wants to merge 1 commit into
estewart08 wants to merge 1 commit into
Conversation
The clang runtime asan library has a different name and is in a new directory when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=On. OFF: lib/clang/<clang-ver>/lib/linux/libclang_rt.asan-x86_64.so ON: lib/clang/<clang-ver>/lib/x86_64-unknown-linux-gnu/libclang_rt.asan.so This will query clang to get the llvm target triple so both locations are searched. ISSUE ID: 6801 (TheRock)
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
Author
|
Similar fix going in for hipblaslt: ROCm/rocm-libraries#10347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clang runtime asan library has a different name and is in a new directory when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=On.
OFF: lib/clang/<clang-ver>/lib/linux/libclang_rt.asan-x86_64.soON: lib/clang/<clang-ver>/lib/x86_64-unknown-linux-gnu/libclang_rt.asan.soThis will query clang to get the llvm target triple so both locations are searched.
ISSUE ID: 6801 (TheRock)
Motivation
Prep work for when TheRock enables -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=On.