Skip to content

fix(rccl): Fix clang_rt search for asan per-target-runtime-dir #9739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
estewart08 wants to merge 1 commit into
base: develop
Choose a base branch
from
+17 −4
Open

fix(rccl): Fix clang_rt search for asan per-target-runtime-dir #9739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions projects/rccl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,23 @@ set(GPU_TARGETS "${DEFAULT_GPUS}" CACHE STRING "Target default GPUs if GPU_TARGE

# Modify GPU architectures for Address Sanitizer builds by appending "xnack+"
if (BUILD_ADDRESS_SANITIZER)
execute_process(
COMMAND ${CMAKE_CXX_COMPILER} -print-file-name=libclang_rt.asan-x86_64.so
OUTPUT_VARIABLE ASAN_RUNTIME_PATH OUTPUT_STRIP_TRAILING_WHITESPACE)
get_filename_component(ASAN_RUNTIME_DIR "${ASAN_RUNTIME_PATH}" DIRECTORY)
set(_suffix "asan")
set(_clang_rt_names "libclang_rt.${_suffix}.so" "libclang_rt.${_suffix}-x86_64.so")
foreach(_clang_rt_name ${_clang_rt_names})
execute_process(
COMMAND ${CMAKE_CXX_COMPILER} -print-file-name=${_clang_rt_name}
OUTPUT_VARIABLE _clang_rt_path OUTPUT_STRIP_TRAILING_WHITESPACE)
# If _clang_rt_path is libclang_rt.asan-x86_64.so
# rather than /path/to/libclang_rt.asan-x86_64.so then
# we failed to locate it.
if(IS_ABSOLUTE "${_clang_rt_path}" AND EXISTS "${_clang_rt_path}")
set(ASAN_RUNTIME_DIR "${_clang_rt_path}")
break()
endif()
endforeach()
if(NOT ASAN_RUNTIME_DIR)
message(FATAL_ERROR "Failed to locate libclang_rt.asan-x86_64.so or libclang_rt.asan.so")
endif()
message(STATUS "ASAN runtime directory: ${ASAN_RUNTIME_DIR}")

SET(amdgpu_targets "")
Expand Down
Loading