Extend release notes to include "announce" #23812
Conversation
SeanCurtis-TRI
added
the
release notes: none
|
+(release notes: none) |
rpoyner-tri
left a comment
rpoyner-tri
left a comment
There was a problem hiding this comment.
Good day, @SeanCurtis-TRI . This PR does not yet have a reviewer assigned. Is it ready for review yet? If yes, then please assign a feature reviewer. If not, then please label it “status: do not review”.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
|
+a:@jwnimmer-tri for review, please. |
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
(We should get at least one more platform person to sign off on the new policy.)
@jwnimmer-tri reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers
doc/_pages/reviewable.md line 142 at r1 (raw file):
replacement or due to some other new change. Only if the deprecation is the _sole_ content of the commit will ``newly deprecated`` be the only label.
BTW We should probably reinforce here that it's safe (and expected) to combine "announce" with other labels, and typically will be combined with "fix" or "feature".
rpoyner-tri
left a comment
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers
SeanCurtis-TRI
force-pushed
the
PR_rel_notes_announce
branch
from
1cf0527 to
283489e
Compare
This accommodates a new release notes tag "announce" which will be included in the "Announcements" sections of the release notes. Documentation is updated accordingly to accommodate it.
SeanCurtis-TRI
force-pushed
the
PR_rel_notes_announce
branch
from
283489e to
cf35e10
Compare
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),jwnimmer-tri(platform)
rpoyner-tri
left a comment
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
|
BTW I've gone ahead and added the corresponding label. |
3 participants
This accommodates a new release notes tag "announce" which will be included in the "Announcements" sections of the release notes. Documentation is updated accordingly to accommodate it.
This change is