Fix set_properties_after_merging when property is boolean. #4084
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introducing bugs in auto_merge
for more information, see https://pre-commit.ci
alejoe91
reviewed
Jul 28, 2025
alejoe91
approved these changes
Jul 28, 2025
zm711
reviewed
Jul 28, 2025
| for key in prop_keys: | ||
| parent_values = sorting_pre_merge.get_property(key) | ||
| if parent_values.dtype.kind not in default_missing_values: | ||
| # if the property is boolean or integer there is no missing values so we skip |
Member
There was a problem hiding this comment.
Just for my info since I don't set properties. You mean that in the case of float you can have a nan or what is a "missing value"?
Member
Author
There was a problem hiding this comment.
a nan for float.
a "" for str
like we have in the base class.
Member
There was a problem hiding this comment.
yes. Missing values are defined here: https://github.com/SpikeInterface/spikeinterface/blob/main/src/spikeinterface/core/base.py#L38
For ints and bool, we don't have missing values :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix set_properties_after_merging when property is boolean.
This was introducing bugs in auto_merge