Skip to content

Fix set_properties_after_merging when property is boolean. #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 4 commits into from
Jul 28, 2025
Merged

Fix set_properties_after_merging when property is boolean. #4084

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d74067
Fix set_properties_after_merging when property is boolean.
samuelgarcia Jul 25, 2025
2e4cde1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 25, 2025
202c068
Update src/spikeinterface/core/sorting_tools.py
alejoe91 Jul 28, 2025
0b0888a
Merge branch 'main' into fix_merge_prop
alejoe91 Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/spikeinterface/core/sorting_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,14 @@ def set_properties_after_merging(
keep_pre_inds = sorting_pre_merge.ids_to_indices(kept_unit_ids)
keep_post_inds = sorting_post_merge.ids_to_indices(kept_unit_ids)

default_missing_values = BaseExtractor.default_missing_property_values

for key in prop_keys:
parent_values = sorting_pre_merge.get_property(key)
if parent_values.dtype.kind not in default_missing_values:
# if the property is boolean or integer there is no missing values so we skip
Copy link
Member

@zm711 zm711 Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my info since I don't set properties. You mean that in the case of float you can have a nan or what is a "missing value"?

Copy link
Member Author

@samuelgarcia samuelgarcia Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nan for float.
a "" for str
like we have in the base class.

Copy link
Member

@alejoe91 alejoe91 Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Missing values are defined here: https://github.com/SpikeInterface/spikeinterface/blob/main/src/spikeinterface/core/base.py#L38

For ints and bool, we don't have missing values :)

Copy link
Member

@zm711 zm711 Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks.

# for instance recursive "is_merged" will not be propagated
continue

# propagate keep values
shape = (len(sorting_post_merge.unit_ids),) + parent_values.shape[1:]
Expand All @@ -377,7 +383,7 @@ def set_properties_after_merging(
# and new values only if they are all similar
new_values[new_index] = merge_values[0]
else:
default_missing_values = BaseExtractor.default_missing_property_values

new_values[new_index] = default_missing_values[parent_values.dtype.kind]
sorting_post_merge.set_property(key, new_values)

Expand Down
Loading