fix: Refactor rotor damage handling to prevent self-inflicted damage and i…

[Vitroze]

Hello,
In some addons, such as GTA:V Helicopters, the Havok self-destructs or directly kills the people inside the helicopter due to its rotor (note that the helicopter is stable).

This PR resolves the issue.

Without the PR
https://github.com/user-attachments/assets/cbfb3f7d-0b68-4ec2-9307-2571e98b34d3
https://github.com/user-attachments/assets/d2c93ca0-67e8-4604-ba6e-f5065ebc74da

With the PR
https://github.com/user-attachments/assets/02866315-1b74-4dfe-b13e-5d60b5784ef9

[StyledStrike]

I really like to fly with the Havok, so I can confirm that this issue does not happen on the servers I played or on single player.
The rotor traces are already ignoring the parent vehicle, so that issue is definitely being caused by some other addon.

[StyledStrike]

I think you will need to figure out what's causing the trace filters to be ignored on your environment instead of this PR, because although this PR prevents the damage, the trace is still hitting things it shouldn't, thus being "used up" and not being able to hit anything else.

[Vitroze]

I have the impression that the problem only occurs in DarkRP.

[Vitroze]

I removed all the modules, but the problem is still there.

[Vitroze]

Hello,
The problem is with VCMOD; I don't know why or how. I'll investigate.
Here is the list of addons installed on the server:

[Vitroze]

Hello,
I found the problem. I implemented a temporary fix because the creator of VCMOD has become inactive and hasn't released any updates in years.

[Astralcircle]

If this is a VCMod issue, then i don't see any reason to bloat glide with fixes like this, i'm also thinking same about #281

[Vitroze]

The problem is that most DarkRP servers still use VCMOD and haven't fully switched to GLide.

The VCMOD developer is inactive and no longer provides support. I think this fix needs to be pushed through, otherwise the servers will still have this issue.

[wrefgtzweve]

that doesn't change the fact that's it's a vcmod issue? don't use deprecated broken addons on your server.

[Vitroze]

VCMOD is one of the most popular Garry's Mod addons. Glide doesn't yet have enough vehicles on the workshop, and conversion is a lengthy process.

For now, VCMOD remains one of the best options.

[wrefgtzweve]

Then fix it in vcmod? Do you not understand clean code? why would glide need vcmod slop to fix a exclusively vcmod issue?
This shouldnt be in glide, this should be fixed in vcmod.
Imagine if every addon just "fixed" their bad code like this, glide would be bloated with random junk for no reason.

[Vitroze]

Obviously, but GLide needs to be compatible with several addons, including the most popular ones.

If I could fix it in VCMOD, I would, but as you probably know, VCMOD is a closed system where we theoretically don't have access to the code.

I think this pull request is useful because VCMOD is still used by a huge number of servers, and if a server only wants to use GLide's aerial functionality and VCMOD for ground vehicles, it won't be able to.

[Vitroze]

Glide bears some responsibility for this bug; VCMOD must be activating a flag on the player or the entity itself. This is a temporary fix; the goal would be to remove the temporary fix and make what VCMOD applies compatible with Glide.

[wrefgtzweve]

Fix it on your server then or make it a separate addon, this should not be part of glide.

[Vitroze]

I understand the problem regarding damage in helicopters.

VCMOD modifies the player's collision to set it to COLLISION_GROUP_WEAPON, which inflicts damage on the player.

[Vitroze]

I understand that implementing this protection solely for VCMOD is problematic in the PR because some contributors want "clean" code.

Therefore, I've changed the focus of this PR to address the VCMOD and Physgun issues. It also adds a new feature: using a convar, you can now choose whether a player can be targeted (via bullets, tracks, etc.) in a glide vehicle. This allows, for example, a player to die on a motorcycle if they are shot.

[wrefgtzweve]

am i talking to a llm? what is this

[Vitroze]

am i talking to a llm? what is this

No, no, it's just that I'm using Google Translate.

This PR allows you to "target" people in a Glide vehicle using their tracks without encountering this type of bug.