Repository navigation
fix(ci): keep mutable advisory audits out of pre-merge gates - #234
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
The YAML-node scanner covers decoded command scalars and conservative job-level exclusions, with regression matrices for the previously missed forms. The fixture-only repair preserves the consumer action bytes. The unit suite and shared-action invocation succeeded at this head; no blocking defects found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extend the existing
workflow-lintnon-deterministic-gate check to reject direct Bun, npm, pnpm and Yarn vulnerability audits in pull-request, merge-group and reusable workflows. Keep its delivered-customer exemption and secret-scanning behavior. Document launch-time audit ownership and advisory-driven updates through the existing bot.Why
An advisory database changes independently of source. A newly published advisory can fail an unchanged PR while the previous main check stays green; every unrelated author then repairs the same dependency. Advisory maintenance belongs to a separate default-branch workflow for launched products, not the pre-merge gate. Unlaunched products defer audits to the final launch review rather than adding daily security work.
Puzzled adopts this guard in a companion workflow change that removes its PR audit while retaining the required
Security Scanjob and verified-secret detection. Its action pin is this exact shared head, so its queue entry is created only after this head has been pushed.How tested
git diff origin/main HEAD --checkpassed.python -m unittest discover -s tests, the existing shared workflow-lint consumer invocation and workflow parsing. The companion Puzzled CI invocation proves the new action pin in an actual consumer.No runtime, schema, dependency version or production state is changed. Rollback is reverting the shared rule and the consumer workflow/pin changes. Indirect package scripts are outside the static guard and are explicitly documented.