Repository navigation
Conversation
🎩 PreviewA preview build has been created at: |
11b2a05 to
007cc6f
Compare
camielvs
left a comment
There was a problem hiding this comment.
🤖 This is an AI-generated code review comment.
This PR surfaces 'Inspect Pipeline' for runs annotated with a backend pipeline id (system/pipeline.id, with a legacy fallback) and routes those inspect actions to the remote editor path, plus a copy clarification in the import dialog. The annotation helper is clean and well-tested, but the change reworks the shared useInspectPipeline hook so its argument now means a full path instead of a pipeline name — and only one of its two callers was updated: RunMenu (live in the v2 run view via RunViewMenuBar) still passes a name, so its 'Inspect Pipeline' now navigates to an invalid/wrong route with no type error and no test to catch it. The remaining notes are a duplicated inspect-path derivation across RunToolbar and useRunViewActions, and a now-dead pipelineName prop at two call sites. I could not run vitest/typecheck/lint (no Node toolchain here) so findings are from static reading, and I could not confirm the exact system/pipeline.id string against the producing backend (oasis-backend was not available), though the legacy key already appears in existing tangle-ui tests and the system/ prefix matches the file's existing convention.
672bd49 to
97b997b
Compare
Mbeaulne
left a comment
There was a problem hiding this comment.
🤖 This is an AI-generated code review comment.
AI-assisted review, posted by Mbeaulne. Comments only, not an approval.
1 finding on this PR: 1 medium. The comment says in plain English what breaks and why, then how to test it, with the technical breakdown collapsed.
One thing that doesn't belong on one line:
- How this was checked: by reading the web app and the backend source (oasis-backend
mainat 0cc14b8 and the upstream backend). It was not run against a live server, so step 3 of the test is the quickest way to confirm it.
fe95ee8 to
fccec1b
Compare
d322ef2 to
4b6f947
Compare
system/pipeline.id is a saved-pipeline search filter, not a run annotation; runs only ever carry tangleml.com/user-pipeline/pipeline-id. Also trims the import dialog copy back to what users need to know. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
4b6f947 to
ff52cac
Compare
Summary
tangleml.com/user-pipeline/pipeline-id)Scope
The backend stamps that annotation only on runs started through its saved-pipeline route (schedules, triggers, scripts). Runs started with the editor's Run button go through the generic
POST /api/pipeline_runs/route and don't carry it yet, so they get no remote Inspect link. The web app can't send the key itself: it's server-owned provenance, and runs inherit access control from the pipeline it names. Follow-up: have the backend stamp provenance on generic submissions after checking the caller's access to the pipeline, then send the pipeline id on submit.Tests
🤖 Generated with Claude Code