reconnectBlocking overload that supports timeout #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipRoman
reviewed
Apr 19, 2025
| * @param timeout The connect timeout | ||
| * @param timeUnit The timeout time unit | ||
| * @return Returns whether it succeeded or not. | ||
| * @throws InterruptedException Thrown when the threads get interrupted |
Collaborator
|
Thanks for your contribution! |
|
Does this fix our Issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an overload to reconnectBlocking method in WebSocketClient class to allow blocking reconnect with timeout.
Related Issue
#1464
Motivation and Context
I need to perform a blocking reconnect with a timeout. There is currently no way to do this without reflection
How Has This Been Tested?
The two commands in the new method were called from outside the class in my use case and it works, there is not much to test here.
Types of changes
Checklist: