Skip to content

reconnectBlocking overload that supports timeout #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilipRoman merged 2 commits into from
Apr 19, 2025
Merged

reconnectBlocking overload that supports timeout #1465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
611d897
Added reconnectBlocking overload that supports timeout in WebSocketCl…
Yuval-Roth Apr 19, 2025
3d8b96f
Added since 1.6.1 in method doc
Yuval-Roth Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/main/java/org/java_websocket/client/WebSocketClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,21 @@ public boolean reconnectBlocking() throws InterruptedException {
return connectBlocking();
}

/**
* Same as <code>reconnect</code> but blocks with a timeout until the websocket connected or failed
* to do so.<br>
*
* @param timeout The connect timeout
* @param timeUnit The timeout time unit
* @return Returns whether it succeeded or not.
* @throws InterruptedException Thrown when the threads get interrupted
Copy link
Collaborator

@PhilipRoman PhilipRoman Apr 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

   * @since 1.6.1

Copy link
Contributor Author

@Yuval-Roth Yuval-Roth Apr 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* @since 1.6.1
*/
public boolean reconnectBlocking(long timeout, TimeUnit timeUnit) throws InterruptedException {
reset();
return connectBlocking(timeout, timeUnit);
}

/**
* Reset everything relevant to allow a reconnect
*
Expand Down