Skip to content

Conversation

@AliveMen
Copy link
Contributor

Set AVaTax transactions (orders) to "committed" in Avalara, after orders synchronization, if order payment status == Paid

Set AVaTax transactions (orders) to "committed" in Avalara, after orders synchronization, if order payment status == paid
@AliveMen AliveMen requested a review from yecli February 26, 2020 10:40
@yecli yecli requested review from avas and tatarincev February 26, 2020 10:42
avas
avas previously approved these changes Feb 26, 2020
@@ -1,8 +1,8 @@
using System;
using Avalara.AvaTax.RestClient;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, using directives for System.* namespaces should be above all other using directives. So, this line should be at line 5, as it was before.

Copy link
Contributor Author

@AliveMen AliveMen Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I remember, in our code style documentation has been written that we should use PowerTools.
Powertools

yecli
yecli previously approved these changes Feb 26, 2020
@lnetrebskii lnetrebskii changed the base branch from dev to support/2.x-dev May 26, 2020 07:19
@lnetrebskii lnetrebskii dismissed stale reviews from yecli and avas May 26, 2020 07:19

The base branch was changed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants