Skip to content

VP-1550 Commit AVaTax transactions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: support/2.x-dev
Choose a base branch
from
Open

VP-1550 Commit AVaTax transactions #12

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce7b34d
VP-1550 Commit AVaTax transactions
AliveMen Feb 26, 2020
dc2739c
Change PaymentStatus to isApproved
AliveMen Feb 26, 2020
7e60611
Set all transaction to Avalara to committed
AliveMen Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions AvaTax.TaxModule.Data/Model/AvaCreateTransactionModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System;
using Avalara.AvaTax.RestClient;
Copy link
Contributor

@avas avas Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, using directives for System.* namespaces should be above all other using directives. So, this line should be at line 5, as it was before.

Copy link
Contributor Author

@AliveMen AliveMen Feb 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I remember, in our code style documentation has been written that we should use PowerTools.
Powertools

using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using Avalara.AvaTax.RestClient;
using VirtoCommerce.Domain.Commerce.Model;
using VirtoCommerce.Domain.Order.Model;
using VirtoCommerce.Domain.Tax.Model;
Expand Down Expand Up @@ -57,6 +57,7 @@ public virtual AvaCreateTransactionModel FromOrder(CustomerOrder order, string r
type = DocumentType.SalesInvoice;
currencyCode = order.Currency;
companyCode = requiredCompanyCode;
commit = true;

var shippingAddress = order.Addresses.FirstOrDefault(x => x.AddressType == AddressType.Shipping);
if (shippingAddress != null && sourceAddress != null)
Expand Down