Inline flowsheet metadata, remove cache tables#305
Merged
jakebromberg merged 5 commits intomainfrom Apr 5, 2026
Merged
Conversation
added 4 commits
April 5, 2026 13:41
Move metadata columns (artwork_url, discogs_url, release_year, streaming URLs, artist_bio, artist_wikipedia_url) directly onto the flowsheet table. Remove the album_metadata and artist_metadata cache tables which duplicated caching already provided by LML and had a cache key mismatch bug that caused metadata to never appear in responses. The metadata service now returns data for the caller to persist rather than writing to separate cache tables. The flowsheet controller fetches metadata from LML fire-and-forget on insert and updates the flowsheet row directly.
FSEntry now includes metadata columns since they're on the flowsheet table, so IFSEntry (which extends FSEntry) requires them at the top level in addition to the nested metadata object.
…d during cleanup)
jakebromberg
force-pushed
the
worktree-refactor+inline-flowsheet-metadata
branch
from
f29ca97 to
3e0a822
Compare
jakebromberg
pushed a commit
that referenced
this pull request
Apr 5, 2026
Replace album_metadata table lookups with flowsheet table queries for artwork enrichment. The album_metadata table is being removed in #305; the flowsheet table now has artwork_url inline. Uses the same normalized key-based matching pattern but queries flowsheet directly.
2 tasks
jakebromberg
force-pushed
the
worktree-refactor+inline-flowsheet-metadata
branch
from
dade551 to
7f930ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
album_metadata/artist_metadatacache tablesCloses #304
Test plan
npm run test:unitpasses (571 tests, verified locally)LIBRARY_METADATA_URLin production environmentPOST /flowsheetwith a track, thenGET /flowsheet— verify metadata fields populate after async fetch