Repository navigation
Don't discard validation failure in wasm2wat --generate-names - #2871
Merged
sbc100 merged 1 commit intoOct 5, 2026
Merged
Conversation
ProgramMain assigned the GenerateNames result over a failed ValidateModule result, so with --generate-names an invalid module was applied names, written out and reported as success. Only generate names once the earlier steps have succeeded.
sbc100
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProgramMainin wasm2wat.cc assigns theGenerateNamesresult over a failedValidateModuleresult, so with--generate-namesan invalid module is still named, written out and reported with exit code 0, and running the spec suite's assert_invalid modules through the tools showed(global f32 (local.get 0))crashing inApplyNames; generate names only once validation has succeeded.