Skip to content

Don't discard validation failure in wasm2wat --generate-names #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Oct 5, 2026
+15 −1
Merged

Don't discard validation failure in wasm2wat --generate-names #2871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/wasm2wat.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ int ProgramMain(int argc, char** argv) {
result = ValidateModule(&module, &errors, options);
}

if (s_generate_names) {
if (Succeeded(result) && s_generate_names) {
result = GenerateNames(&module);
}

Expand Down
14 changes: 14 additions & 0 deletions test/binary/bad-init-expr-generate-names.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
;;; TOOL: run-gen-wasm-bad
;;; ARGS2: --generate-names
magic
version
section(GLOBAL) {
count[1]
type[f32] mut[0] init_expr[local.get 0 end]
}
(;; STDERR ;;;
out/test/binary/bad-init-expr-generate-names/bad-init-expr-generate-names.wasm:000000f: error: invalid initializer: instruction not valid in initializer expression: local.get
out/test/binary/bad-init-expr-generate-names/bad-init-expr-generate-names.wasm:000000f: error: type mismatch in initializer expression, expected [f32] but got []
out/test/binary/bad-init-expr-generate-names/bad-init-expr-generate-names.wasm:000000f: error: invalid initializer: instruction not valid in initializer expression: local.get
out/test/binary/bad-init-expr-generate-names/bad-init-expr-generate-names.wasm:000000f: error: type mismatch in initializer expression, expected [f32] but got []
;;; STDERR ;;)
Loading