feat: STM32 Add option for UART to use DMA for sending byte #796
+8,578
−4,935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Lint Results
Found 3 issues on changed lines in 1 file:
- port/stmicro/stm32/src/hals/common/bdma_v1.zig: 3 issues
ℹ️ Additional issues on unchanged lines
The following 14 issue(s) exist but are not on lines changed in this PR:
build.zig:405: TODO style comments need to have a linked microzig issue on the same line.
build.zig:658: TODO style comments need to have a linked microzig issue on the same line.
build.zig:698: TODO style comments need to have a linked microzig issue on the same line.
build.zig:714: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:40: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:46: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:51: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:52: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:665: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/generate.zig:269: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:83: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:85: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:88: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.
github-actions
bot
dismissed
their stale review
Updating with new lint results
There was a problem hiding this comment.
🔍 Lint Results
Found 1 issue on changed lines in 1 file:
- port/stmicro/stm32/src/hals/common/bdma_v1.zig: 1 issue
ℹ️ Additional issues on unchanged lines
The following 23 issue(s) exist but are not on lines changed in this PR:
build.zig:405: TODO style comments need to have a linked microzig issue on the same line.
build.zig:658: TODO style comments need to have a linked microzig issue on the same line.
build.zig:698: TODO style comments need to have a linked microzig issue on the same line.
build.zig:714: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:40: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:46: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:51: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:52: TODO style comments need to have a linked microzig issue on the same line.
core/src/cpus/cortex_m.zig:665: TODO style comments need to have a linked microzig issue on the same line.
examples/stmicro/stm32/build.zig:18: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/generate.zig:269: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:1: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:120: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:122: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:285: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:439: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:561: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:577: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:83: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:85: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:88: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.
| self.in_progress = false; | ||
| } | ||
|
|
||
| // TODO: Handle the error case |
There was a problem hiding this comment.
TODO style comments need to have a linked microzig issue on the same line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.