Nonce Aware Verifier#589
Open
nodh wants to merge 3 commits into
Open
Conversation
Open
JesusMcCloud
approved these changes
Jul 8, 2026
JesusMcCloud
left a comment
JesusMcCloud
left a comment
Collaborator
There was a problem hiding this comment.
At your discretion, but maybe we should just tackle focused concurrent testing and stress testing in a separate PR
Comment on lines
+122
to
+127
| val authnResponse = it.holderOid4vp.createAuthnResponse(authnRequest).getOrThrow() | ||
| .shouldBeInstanceOf<AuthenticationResponseResult.Redirect>() | ||
|
|
||
| it.verifierOid4vp.validateAuthnResponse(authnResponse.url).getOrThrow() | ||
| it.verifierOid4vp.validateAuthnResponse(authnResponse.url).isFailure shouldBe true | ||
| } |
Collaborator
There was a problem hiding this comment.
Prime candidate to be executed concurrently like there's no tomorrow: concurrently create requests, once all are there, concurrently create responses and assert nonces are invalidated
gp-iaik
reviewed
Jul 8, 2026
| private fun AuthnResponseResult.isFullyValid(): Boolean = | ||
| idTokenValidationResult?.isFailure != true && | ||
| vpTokenValidationResult?.isFailure != true && | ||
| (vpTokenValidationResult?.getOrNull()?.isFullyValid() ?: true) |
Collaborator
There was a problem hiding this comment.
Shouldn't this better be ?: false?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of a better interface for DCAPI: Extract some nonce handling into the verifier.
Next PR: #590