DCAPI Verifier#590
Open
nodh wants to merge 4 commits into
Open
Conversation
JesusMcCloud
requested changes
Jul 8, 2026
| } | ||
|
|
||
| /** | ||
| * Extract and verifies verifiable presentations, according to format defined in |
| ).getOrThrow() | ||
| } | ||
|
|
||
| // TODO: Validation errors are (sometimes) put into a VerifiableDCQLPresentationValidationResults which means that the success page is shown |
Collaborator
There was a problem hiding this comment.
Sounds like the HTTP client needs a better error handler
| } | ||
|
|
||
| /** | ||
| * Extract and verifies verifiable presentations, according to format defined in |
Collaborator
There was a problem hiding this comment.
Actually, this is the same comment the other one missing the s. Copy-paste error or correct?
Collaborator
There was a problem hiding this comment.
is this comment or is it not correct?
| * show the information to the user, | ||
| * and create the response in [finalizeAuthorizationResponse], and send it back to the verifier. | ||
| */ | ||
| // TODO Maybe also one for DCAPI? |
Member
Author
There was a problem hiding this comment.
Thinking of the upcoming PR: probably not
gp-iaik
reviewed
Jul 8, 2026
|
|
||
| /** | ||
| * Implements a verifier for the []Digital Credential API](https://www.w3.org/TR/digital-credentials/), | ||
| * similar to [OpenId4VpVerifier] for OpenID4VP. |
Collaborator
There was a problem hiding this comment.
DC API is also part of OpenID4VP, so this is a bit ambiguous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of a better interface for DCAPI: Dedicated
DcApiVerifierto streamline theOpenId4VpVerifier. Next step: IntegrateIso180137AnnexCVerifierinto that.Previous PR: #589
Next PR: #591