Skip to content

fix(test): drop stale get_products_refine allowlist on proposal-mode adapter #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
May 8, 2026
Merged

fix(test): drop stale get_products_refine allowlist on proposal-mode adapter #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/fix-proposal-mode-stale-allowlist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@adcp/sdk": patch
---

fix(test): retarget proposal-mode allowlist after AdCP 3.0.7 cascade unmask

The 3.0.7 schema bump (#1595) landed adcp#4088, fixing `proposal_id` chaining in `proposal_finalize.yaml`. `get_products_refine` now passes — and the cascade-skip that hid `create_media_buy` is gone, exposing a real adapter bug: `create_media_buy`'s response doesn't satisfy the 3.0.7 `create-media-buy-response.json` schema. Allowlist retargeted to mask `create_media_buy` until the adapter is fixed (tracked at #1600). Unblocks main CI.
20 changes: 7 additions & 13 deletions test/examples/hello-seller-adapter-proposal-mode.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,13 @@ const { runHelloAdapterGates } = require('./_helpers/runHelloAdapterGates');
const REPO_ROOT = path.resolve(__dirname, '..', '..');
const STORYBOARD_ID = 'media_buy_seller/proposal_finalize';

// Storyboard scenarios that fail because `proposal_finalize.yaml` doesn't
// declare `context_outputs` / `context_inputs` to chain the seller's
// freshly-minted `proposal_id` from `brief_with_proposals` into the
// subsequent `refine_proposal` / `finalize_proposal` steps. The runner
// sends the literal `balanced_reach_q2` from the spec yaml's
// `sample_request`, the adapter forwards it to the upstream where no
// such proposal exists, and the upstream 404s. Tracked at
// adcontextprotocol/adcp#4086 + draft PR #4088 (storyboard fix).
//
// When #4088 lands and the schema cache updates, the chained
// `$context.proposal_id` will replace the placeholder and refine →
// finalize → accept will pass end-to-end. Drop this allowlist entry then.
const EXPECTED_FAILURES = [{ storyboard_id: STORYBOARD_ID, step_id: 'get_products_refine' }];
// AdCP 3.0.7 (#1595) landed adcp#4088, which fixed `proposal_id` chaining
// in `proposal_finalize.yaml`. `get_products_refine` now passes — but the
// cascade-skip that previously hid `create_media_buy` is also gone,
// exposing a real adapter bug: the adapter's `create_media_buy` response
// doesn't satisfy the 3.0.7 `create-media-buy-response.json` schema.
// Tracked at #1600 — drop this allowlist entry when the adapter is fixed.
const EXPECTED_FAILURES = [{ storyboard_id: STORYBOARD_ID, step_id: 'create_media_buy' }];

function isExpectedFailure(f) {
return EXPECTED_FAILURES.some(e => e.storyboard_id === (f.storyboard_id || '') && e.step_id === (f.step_id || ''));
Expand Down
Loading