Conversation
AdCP 3.0.7 (#1595) landed adcp#4088, fixing proposal_id chaining in proposal_finalize.yaml. get_products_refine now passes — and the cascade-skip that hid create_media_buy is gone, exposing a real adapter bug: create_media_buy's response doesn't satisfy the 3.0.7 create-media-buy-response.json schema. Allowlist retargeted to mask create_media_buy until the adapter is fixed (tracked at #1600). Unblocks main CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley
force-pushed
the
bokelley/fix-proposal-mode-stale-allowlist
branch
from
1d01e59 to
acd4eeb
Compare
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main is currently red on the proposal-mode adapter gate. The AdCP 3.0.7 schema bump (#1595) landed adcp#4088, which adds
context_outputs/context_inputschaining forproposal_idinproposal_finalize.yaml. Downstream phases now resolve the seller's freshly-mintedproposal_idinstead of the literalbalanced_reach_q2placeholder, soget_products_refineis no longer expected to fail.The staleness guard from #1594 fired correctly — that's the design. This PR drops the now-unneeded allowlist entry.
Why this matters now
Main has been red since the 3.0.7 bump merged at 13:13 UTC. All open PRs (#1597, #1598) are blocked on this same failure.
Test plan
Test & Buildjob passes on the proposal-mode adapter step.