Conversation
…nalize + sales-proposal-mode storyboards Both storyboards were sending the static placeholder "balanced_reach_q2" as proposal_id in refine/finalize/accept steps. Proposal-mode sellers (runtime UUIDs, DB rowids) received 404s on their upstreams. Catalog-mode sellers with stable IDs are unaffected — the chained value is identical to the prior literal for any seller whose brief step returns the same ID. - Add context_outputs on brief_with_proposals/get_products_brief in both storyboards to capture proposals[0].proposal_id into the context accumulator - Replace "balanced_reach_q2" with "$context.proposal_id" in refine, finalize, and accept steps of both storyboards - Add field_present validation for proposal_id echo on create_media_buy response - Add optional proposal_id field to CreateMediaBuySuccess schema to document the echo contract (non-breaking additive change; additionalProperties: true already permitted it) Fixes #4086 https://claude.ai/code/session_01CvVpewM8Xh3bG49S8QGZoM
Contributor
Author
|
This PR was opened by the triage routine. See issue #4086 for context. Generated by Claude Code |
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4086
Both
media_buy_seller/proposal_finalizeandsales-proposal-modestoryboards were sending the literal string"balanced_reach_q2"asproposal_idin their refine/finalize/accept steps. Proposal-mode sellers with runtime-generated IDs (UUIDs, DB rowids) received 404s from their upstreams on those steps. The fix addscontext_outputson thebrief_with_proposalsstep to capture the seller-mintedproposal_id, then substitutes$context.proposal_idin every subsequent step that references it. Catalog-mode sellers with stable IDs are unaffected — the chained value equals the old literal for any seller whose brief step returns the same ID.Non-breaking justification: Adds optional
context_outputschaining to existing storyboard steps (additive) and an optionalproposal_idproperty toCreateMediaBuySuccessschema (additive,additionalProperties: truealready permitted the field). No existing fields renamed or removed.Scope note: The protocol expert flagged that
sales-proposal-mode/index.yamlcarries the identical"balanced_reach_q2"placeholder bug. Both files are fixed in this PR rather than a separate follow-up to avoid the "small follow-up gets lost while the parent ships and re-opens the same file" failure mode.Open follow-on (not in scope):
finalize_proposal/get_products_finalizehas prose-only assertions forproposals[0].proposal_status: committedandproposals[0].expires_at. Adding machine-checkablefield_value/field_presentvalidations for those would improve coverage — filed separately.Pre-PR review:
name+pathoncontext_outputs,$context.<name>insample_request) is correct;context_outputsonstateful: falsestep is valid per schema; one nit (missing blank line before- id: review_refine) fixed before commitproposals[0]index convention matches corpus; addedproposal_idas optional property toCreateMediaBuySuccessto resolve thefield_presentvalidation's blocker risk (schema didn't previously declare the field)Session: https://claude.ai/code/session_01CvVpewM8Xh3bG49S8QGZoM
Generated by Claude Code