Skip to content

fix(release): retry GitHub compare requests - #2021

Merged
hshoff merged 1 commit into
masterfrom
harry/visx-release-compare-retry
Jun 18, 2026
Merged

fix(release): retry GitHub compare requests#2021
hshoff merged 1 commit into
masterfrom
harry/visx-release-compare-retry

Conversation

@hshoff

@hshoff hshoff commented Jun 18, 2026

Copy link
Copy Markdown
Member

Why retry release compare requests?

The push workflow for feat(tooltip): add Floating UI tooltip primitives (#2020) failed in the release step while fetching commits from GitHub's compare endpoint.

This PR hardens that fetch path so transient GitHub response/body failures use the same retry helper as the rest of the release metadata requests.

馃挜 Breaking Changes

  • None.

馃殌 Enhancements

  • None.

馃摑 Documentation

  • None.

馃悰 Bug Fix

  • Retry the release compare request used to fetch commits since the latest tag.
  • Treat transient GitHub request failures such as Premature close, socket resets, timeout-style errors, and 5xx responses as retryable.

馃彔 Internal

  • Reuse the release script's existing GitHub request retry helper for fetchCommitsSinceTag.

Validation

  • yarn lint
  • git diff --check

@hshoff hshoff changed the title visx: retry release compare requests fix(release): retry GitHub compare requests Jun 18, 2026
@hshoff
hshoff force-pushed the harry/visx-release-compare-retry branch from e33f152 to 944da0e Compare June 18, 2026 16:55
@hshoff hshoff added this to the 4.1.0 milestone Jun 18, 2026
@hshoff hshoff self-assigned this Jun 18, 2026
@hshoff
hshoff requested a review from Copilot June 18, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the release automation鈥檚 GitHub compare request path by routing the compare call through the existing retry helper and expanding the helper鈥檚 definition of retryable failures to include common transient network and 5xx errors.

Changes:

  • Expand runGithubRequestWithRetries to retry on GitHub 5xx responses and common transient network/body failures (in addition to rate limiting).
  • Update fetchCommitsSinceTag to use runGithubRequestWithRetries for the compare endpoint call.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/performRelease/runGithubRequestWithRetries.ts Broadens retry detection beyond rate limits to include 5xx + transient network/body errors; updates warning message accordingly.
scripts/performRelease/fetchCommitsSinceTag.ts Wraps the GitHub compare request in the shared retry helper to avoid transient failures breaking releases.

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hshoff
hshoff merged commit 01fa712 into master Jun 18, 2026
2 checks passed
@hshoff hshoff removed this from the 4.1.0 milestone Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants