fix(release): retry GitHub compare requests - #2021
Merged
Merged
Conversation
hshoff
force-pushed
the
harry/visx-release-compare-retry
branch
from
June 18, 2026 16:55
e33f152 to
944da0e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the release automation鈥檚 GitHub compare request path by routing the compare call through the existing retry helper and expanding the helper鈥檚 definition of retryable failures to include common transient network and 5xx errors.
Changes:
- Expand
runGithubRequestWithRetriesto retry on GitHub 5xx responses and common transient network/body failures (in addition to rate limiting). - Update
fetchCommitsSinceTagto userunGithubRequestWithRetriesfor the compare endpoint call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/performRelease/runGithubRequestWithRetries.ts | Broadens retry detection beyond rate limits to include 5xx + transient network/body errors; updates warning message accordingly. |
| scripts/performRelease/fetchCommitsSinceTag.ts | Wraps the GitHub compare request in the shared retry helper to avoid transient failures breaking releases. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why retry release compare requests?
The push workflow for
feat(tooltip): add Floating UI tooltip primitives (#2020)failed in the release step while fetching commits from GitHub's compare endpoint.This PR hardens that fetch path so transient GitHub response/body failures use the same retry helper as the rest of the release metadata requests.
馃挜 Breaking Changes
馃殌 Enhancements
馃摑 Documentation
馃悰 Bug Fix
Premature close, socket resets, timeout-style errors, and 5xx responses as retryable.馃彔 Internal
fetchCommitsSinceTag.Validation
yarn lintgit diff --check