FIX: remove deprecated pandas CSV reader args (keep_date_col, verbose, delim_whitespace)#1418
Open
iprithv wants to merge 1 commit intoapache:mainfrom
Open
FIX: remove deprecated pandas CSV reader args (keep_date_col, verbose, delim_whitespace)#1418iprithv wants to merge 1 commit intoapache:mainfrom
iprithv wants to merge 1 commit intoapache:mainfrom
Conversation
…, delim_whitespace) Signed-off-by: prithvi <prithvi@cloudera.com>
skrawcz
requested changes
Dec 28, 2025
Contributor
skrawcz
left a comment
There was a problem hiding this comment.
Thanks @iprithv.
Sorry it took so long to review.
Great start. One concern, we need to make this backwards compatible. We currently don't have a minimum pandas version.
So please:
- Make this check the pandas version to selectively exclude things.
- Add comments in the "constructor" for these values that they are not used if pandas is greater than X.
Contributor
|
Hi @skrawcz, seems like he is offline. I can pick this small fix. |
6 tasks
Contributor
Yeah something like that. So allow it for pandas versions it's valid for, and then remove it for pandas versions it can't be used in. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fix: remove deprecated pandas CSV reader args (
keep_date_col,verbose,delim_whitespace)fixes #1417
These pandas arguments are deprecated and generate warnings during the test suite.
This PR removes them from Hamilton’s
PandasCSVReaderto maintain future compatibility and keep test output clean.Changes
keep_date_colverbosedelim_whitespace_get_loading_kwargs()to avoid passing these keywords.How I tested this
Notes
Checklist