fixed the deprecated functions #1444
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Contributor
Author
|
@skrawcz , can you please review this and let me know if any changes are required |
skrawcz
reviewed
Jan 19, 2026
skrawcz
reviewed
Jan 19, 2026
skrawcz
reviewed
Jan 19, 2026
skrawcz
requested changes
Jan 19, 2026
Contributor
skrawcz
left a comment
skrawcz
left a comment
There was a problem hiding this comment.
In the right direction. Some changes please.
… changes for delim_whitespace
skrawcz
reviewed
Jan 19, 2026
| kwargs["storage_options"] = self.storage_options | ||
| if pd.__version__ >= "2.0" and self.dtype_backend is not None: | ||
| kwargs["dtype_backend"] = self.dtype_backend | ||
| if pandas_version < Version("2.0"): |
Contributor
There was a problem hiding this comment.
You need to import Version at the top of the file -- then tests should pass...
skrawcz
reviewed
Jan 19, 2026
Contributor
skrawcz
left a comment
skrawcz
left a comment
There was a problem hiding this comment.
thanks for the changes -- just need to get CI to pass now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the #1417 to remove the deprecated pandas CSV reader args. Fixed by adding a variable for identifying the pandas version and updated the functions to add them into kwargs only the version is less than 2.0
Changes
How I tested this
Checklist