-
Notifications
You must be signed in to change notification settings - Fork 676
signals: fix dependency issues when signals are all disabled #3333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wangchdo
wants to merge
1
commit into
apache:master
Choose a base branch
from
wangchdo:enable_disable_all_signals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+172
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
previously approved these changes
Jan 15, 2026
e1cf0b0 to
0625200
Compare
0625200 to
cf6a657
Compare
cf6a657 to
e3804fa
Compare
af94348 to
0cc5a9a
Compare
66096e1 to
62f6066
Compare
62f6066 to
8610764
Compare
8610764 to
f6bf01a
Compare
xiaoxiang781216
previously approved these changes
Jan 17, 2026
f6bf01a to
7f9a65d
Compare
Fix build and runtime issues when signals all disabled. Signed-off-by: Chengdong Wang <[email protected]>
7f9a65d to
0b1eef6
Compare
xiaoxiang781216
approved these changes
Jan 18, 2026
xiaoxiang781216
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build and runtime issues when signals all disabled.
Summary
This PR fixes dependency issues when signals are all disabled
Impact
Fix dependency issues when signals are all disabled, no impact to any existing functions
Testing
ostest passed on rv-virt:smp64
disable all signals
ostest passed log